Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update generate params (#112) #120

Merged
merged 1 commit into from
Aug 1, 2023
Merged

Update generate params (#112) #120

merged 1 commit into from
Aug 1, 2023

Conversation

Tomas2D
Copy link
Member

@Tomas2D Tomas2D commented Jul 31, 2023 •
edited
Loading

Status

READY

Description

Generate Inputs, Tests

Which issue(s) does this pull-request fix?

Closes: #112

Checklist

  • Automated tests exist
  • Updated Package Requirements (if required, and with maintainers' approval)
  • Local unit tests performed
  • Documentation exists link
  • Local pre-commit hooks performed
  • Desired commit message set as PR title and description set above
  • Link to relevant GitHub issue provided

@Tomas2D Tomas2D requested a review from vedem1192 July 31, 2023 17:01
@Tomas2D Tomas2D changed the base branch from main to develop July 31, 2023 17:01
@coveralls
Copy link

coveralls commented Jul 31, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 5717480043

  • 10 of 10 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.005%) to 96.224%
Totals Coverage Status
Change from base Build 5681617769: 0.005%
Covered Lines: 1886
Relevant Lines: 1960
💛 - Coveralls

onkarbhardwaj
onkarbhardwaj approved these changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@onkarbhardwaj onkarbhardwaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks.

@vedem1192
Copy link
Contributor

Some of these limits are from the internal schema.

@vedem1192 vedem1192 merged commit 703edd3 into IBM:develop Aug 1, 2023
4 checks passed
@Tomas2D Tomas2D deleted the 112-update-generate-params branch September 26, 2023 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onkarbhardwaj onkarbhardwaj onkarbhardwaj approved these changes

@vedem1192 vedem1192 vedem1192 approved these changes

@jpwsutton jpwsutton Awaiting requested review from jpwsutton

@moneill0 moneill0 Awaiting requested review from moneill0

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add missing parameters from /v1 endpoint
4 participants
@Tomas2D @coveralls @vedem1192 @onkarbhardwaj