Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update wrong import class of credential #122

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

jayolee
Copy link
Contributor

@jayolee jayolee commented Aug 1, 2023

Status

READY

Description

  • Updated importing credentials from genai.model to genai.credentials from GETTING_STARTED.md and watsonx-prompt-templating example to avoid possible side effect in the future and user following a wrong pattern.

Impacted Areas in Library

  • GETTING_STARTED.md
  • examples/user/prompt_templating/watsonx-prompt-templating.py

Which issue(s) does this pull-request fix?

Closes: #121


Checklist

  • Automated tests exist
  • Updated Package Requirements (if required, and with maintainers' approval)
  • Local unit tests performed
  • Documentation exists link
  • Local pre-commit hooks performed
  • Desired commit message set as PR title and description set above
  • Link to relevant GitHub issue provided

- Updated importing credentials from genai.model to genai.credentials from GETTING_STARTED.md and watsonx-prompt-templating example

Contributes to: IBM#121

Signed-off-by: Ja Young Lee <younglee@ibm.com>
@jayolee jayolee self-assigned this Aug 1, 2023
@jayolee jayolee linked an issue Aug 1, 2023 that may be closed by this pull request
@coveralls
Copy link

coveralls commented Aug 1, 2023

Pull Request Test Coverage Report for Build 5726615842

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.219%

Totals Coverage Status
Change from base Build 5681617769: 0.0%
Covered Lines: 1883
Relevant Lines: 1957

💛 - Coveralls

@vedem1192 vedem1192 merged commit c6e47e3 into IBM:develop Aug 1, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOCS: Import updates on README
4 participants