update greedy examples removing incompatible params #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mírian Silva <mirianfrsilva@ibm.com>
mirianfsilva
changed the title
Pull Request Test Coverage Report for Build 5357359733
💛 - Coveralls |
Signed-off-by: Mírian Silva <mirianfrsilva@ibm.com>
jayolee
approved these changes
Jun 23, 2023
onkarbhardwaj
approved these changes
Jun 23, 2023
onkarbhardwaj
added a commit
that referenced
this pull request
Jun 23, 2023
* Informative error messages in async generator and type change in GenAI exception (#57) * update greedy examples removing incompatible params (#59) * Fix/setup cfg (#49) * fix: including README in pypi deployment * fix: adding build dependency and changing workflow to use it Signed-off-by: James Sutton <james.sutton@uk.ibm.com> Co-authored-by: Mírian Silva <mirianfrsilva@ibm.com> Co-authored-by: James Sutton <1068763+jpwsutton@users.noreply.github.com>
moneill0
pushed a commit
to moneill0/ibm-generative-ai
that referenced
this pull request
Jun 29, 2023
* Informative error messages in async generator and type change in GenAI exception (IBM#57) * update greedy examples removing incompatible params (IBM#59) * Fix/setup cfg (IBM#49) * fix: including README in pypi deployment * fix: adding build dependency and changing workflow to use it Signed-off-by: James Sutton <james.sutton@uk.ibm.com> Co-authored-by: Mírian Silva <mirianfrsilva@ibm.com> Co-authored-by: James Sutton <1068763+jpwsutton@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY
Description
Updated examples that were using incompatible parameters with the greedy method.
Impacted Areas in Library
User Examples.
Which issue(s) does this pull-request fix?
#58
Any special notes for your reviewer?
Checklist