Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/setup cfg #49

Merged
merged 2 commits into from
Jun 23, 2023
Merged

Fix/setup cfg #49

merged 2 commits into from
Jun 23, 2023

Conversation

jpwsutton
Copy link
Member

@jpwsutton jpwsutton commented Jun 21, 2023


Status

READY

Description

  • Changes the build process to build all assets required, not just the wheel.
    This should then automatically push the latest README.md file to pypi

Impacted Areas in Library

  • Build
  • Publish workflow

Which issue(s) does this pull-request fix?

Closes: #43

Signed-off-by: James Sutton <james.sutton@uk.ibm.com>
Signed-off-by: James Sutton <james.sutton@uk.ibm.com>
@coveralls
Copy link

coveralls commented Jun 21, 2023

Pull Request Test Coverage Report for Build 5335514841

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.043%

Totals Coverage Status
Change from base Build 5323925911: 0.0%
Covered Lines: 1018
Relevant Lines: 1106

💛 - Coveralls

@jpwsutton jpwsutton marked this pull request as ready for review June 23, 2023 13:56
@onkarbhardwaj onkarbhardwaj self-requested a review June 23, 2023 15:06
@onkarbhardwaj onkarbhardwaj merged commit e898e2e into IBM:develop Jun 23, 2023
onkarbhardwaj added a commit that referenced this pull request Jun 23, 2023
* Informative error messages in async generator and type change in GenAI exception (#57)

* update greedy examples removing incompatible params (#59)

* Fix/setup cfg (#49)

* fix: including README in pypi deployment

* fix: adding build dependency and changing workflow to use it


Signed-off-by: James Sutton <james.sutton@uk.ibm.com>
Co-authored-by: Mírian Silva <mirianfrsilva@ibm.com>
Co-authored-by: James Sutton <1068763+jpwsutton@users.noreply.github.com>
moneill0 pushed a commit to moneill0/ibm-generative-ai that referenced this pull request Jun 29, 2023
* Informative error messages in async generator and type change in GenAI exception (IBM#57)

* update greedy examples removing incompatible params (IBM#59)

* Fix/setup cfg (IBM#49)

* fix: including README in pypi deployment

* fix: adding build dependency and changing workflow to use it


Signed-off-by: James Sutton <james.sutton@uk.ibm.com>
Co-authored-by: Mírian Silva <mirianfrsilva@ibm.com>
Co-authored-by: James Sutton <1068763+jpwsutton@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants