-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add mlx single deployment #33
Conversation
follow the instructions here to install kustomize. Then run the following commands git clone https://github.com/IBM/manifests -b v1.4.0-mlx
cd manifests
# run the below command two times if the CRDs take too long to provision.
while ! kustomize build mlx-single | kubectl apply -f -; do echo "Retrying to apply resources"; sleep 10; done Let me know there's any bugs or failure in this manifest |
Hi Tommy, I had to make changes to the diff --git a/mlx-single/kustomization.yaml b/mlx-single/kustomization.yaml
index 912ffe1c..9358987d 100644
--- a/mlx-single/kustomization.yaml
+++ b/mlx-single/kustomization.yaml
@@ -3,19 +3,18 @@ kind: Kustomization
resources:
# Istio
-- ../distributions/stacks/ibm/application/istio-1-9-0
+- ../dist/stacks/ibm/application/istio-1-9-0
# Kubeflow namespace (required)
-- ../distributions/stacks/ibm/application/kubeflow-namespace
+- ../dist/stacks/ibm/application/kubeflow-namespace
# Kubeflow Roles (required)
-- ../distributions/stacks/ibm/application/kubeflow-roles
+- ../dist/stacks/ibm/application/kubeflow-roles
# Kubeflow istio resource (required)
-- ../distributions/stacks/ibm/application/kubeflow-istio-resources
+- ../dist/stacks/ibm/application/kubeflow-istio-resources
# Kubeflow Pipelines with Tekton
-- ../distributions/stacks/openshift/application/kfp-tekton
+- ../dist/stacks/ibm/application/kfp-tekton
# Datashim
- ../contrib/datashim/base
# MLX
- ../contrib/mlx/base
- |
But after that I get this error:
|
adding the line |
Thanks for the updates. This works great now! Is there any remaining work to get this PR merged? |
@yhwang you think we could merge this pr? This should be just the minimum deployment for MLX and doesn't impact the upstream deployment. |
then we can migrate this patch to 1.5 and upstream branch |
this goes to 1.4. Do we need to get this to mater then v1.5-branch? |
@yhwang we need to update the kustomization.yaml file to match with v1.5 and master |
then merge them |
Which issue is resolved by this Pull Request:
Resolves #
Description of your changes:
Add mlx single deployment
Checklist:
Make sure you have installed kustomize == 3.2.1
make generate-changed-only
make test