Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add mlx single deployment #33

Merged
merged 4 commits into from
Jun 9, 2022
Merged

add mlx single deployment #33

merged 4 commits into from
Jun 9, 2022

Conversation

Tomcli
Copy link

@Tomcli Tomcli commented Nov 17, 2021

Which issue is resolved by this Pull Request:
Resolves #

Description of your changes:
Add mlx single deployment

Checklist:

  • Unit tests pass:
    Make sure you have installed kustomize == 3.2.1
    1. make generate-changed-only
    2. make test

@Tomcli
Copy link
Author

Tomcli commented Nov 17, 2021

@ckadner

follow the instructions here to install kustomize. Then run the following commands
https://github.com/machine-learning-exchange/mlx/blob/main/docs/mlx-setup.md

git clone https://github.com/IBM/manifests -b v1.4.0-mlx
cd manifests
# run the below command two times if the CRDs take too long to provision.
while ! kustomize build mlx-single | kubectl apply -f -; do echo "Retrying to apply resources"; sleep 10; done

Let me know there's any bugs or failure in this manifest

@ckadner
Copy link

ckadner commented Nov 24, 2021

Hi Tommy, I had to make changes to the mlx-single/kustomization.yaml

diff --git a/mlx-single/kustomization.yaml b/mlx-single/kustomization.yaml
index 912ffe1c..9358987d 100644
--- a/mlx-single/kustomization.yaml
+++ b/mlx-single/kustomization.yaml
@@ -3,19 +3,18 @@ kind: Kustomization

 resources:
 # Istio
-- ../distributions/stacks/ibm/application/istio-1-9-0
+- ../dist/stacks/ibm/application/istio-1-9-0
 # Kubeflow namespace (required)
-- ../distributions/stacks/ibm/application/kubeflow-namespace
+- ../dist/stacks/ibm/application/kubeflow-namespace
 # Kubeflow Roles (required)
-- ../distributions/stacks/ibm/application/kubeflow-roles
+- ../dist/stacks/ibm/application/kubeflow-roles
 # Kubeflow istio resource (required)
-- ../distributions/stacks/ibm/application/kubeflow-istio-resources
+- ../dist/stacks/ibm/application/kubeflow-istio-resources


 # Kubeflow Pipelines with Tekton
-- ../distributions/stacks/openshift/application/kfp-tekton
+- ../dist/stacks/ibm/application/kfp-tekton
 # Datashim
 - ../contrib/datashim/base
 # MLX
 - ../contrib/mlx/base
-

@ckadner
Copy link

ckadner commented Nov 24, 2021

But after that I get this error:

error: unable to recognize "STDIN": no matches for kind "Profile" in version "kubeflow.org/v1"

@ckadner
Copy link

ckadner commented Nov 24, 2021

But after that I get this error:

error: unable to recognize "STDIN": no matches for kind "Profile" in version "kubeflow.org/v1"

adding the line - ../dist/stacks/ibm/application/profiles to the mlx-single/kustomization.yaml took care of that error

@ckadner
Copy link

ckadner commented Dec 4, 2021

Thanks for the updates. This works great now! Is there any remaining work to get this PR merged?

@Tomcli
Copy link
Author

Tomcli commented Jun 9, 2022

@yhwang you think we could merge this pr? This should be just the minimum deployment for MLX and doesn't impact the upstream deployment.

@Tomcli
Copy link
Author

Tomcli commented Jun 9, 2022

then we can migrate this patch to 1.5 and upstream branch

@yhwang yhwang merged commit 43c46fe into v1.4.0 Jun 9, 2022
@yhwang
Copy link
Member

yhwang commented Jun 9, 2022

this goes to 1.4. Do we need to get this to mater then v1.5-branch?

@Tomcli
Copy link
Author

Tomcli commented Jun 9, 2022

@yhwang we need to update the kustomization.yaml file to match with v1.5 and master

@Tomcli
Copy link
Author

Tomcli commented Jun 9, 2022

then merge them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants