fix: support disableSslVerification when user provides custom httpsAgent
#104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Agent before, if a user set `disableSslVerification` to true and also provided their own httpsAgent (to configure a proxy, etc), the disableSslVerification handling would be overwritten now, the code will update the users agent to support this flag
dpopp07
commented
Aug 5, 2020
| @@ -26,9 +27,6 @@ import logger from './logger'; | |||
| const isBrowser = typeof window === 'object'; | |||
| const globalTransactionId = 'x-global-transaction-id'; | |||
|
|
|||
| // Limit the type of axios configs to be customizable | |||
| const allowedAxiosConfig = ['transformRequest', 'transformResponse', 'paramsSerializer', 'paramsSerializer', 'timeout', 'withCredentials', 'adapter', 'responseType', 'responseEncoding', 'xsrfCookieName', 'xsrfHeaderName', 'onUploadProgress', 'onDownloadProgress', 'maxContentLength', 'validateStatus', 'maxRedirects', 'socketPath', 'httpAgent', 'httpsAgent', 'proxy', 'cancelToken', 'jar']; | |||
|
|
|||
There was a problem hiding this comment.
I never liked this code and it was actually causing some strange behavior, so I removed it entirely.
ibm-devx-automation
pushed a commit
that referenced
this pull request
Aug 5, 2020
## [2.4.3](v2.4.2...v2.4.3) (2020-08-05) ### Bug Fixes * support `disableSslVerification` when user provides custom httpsAgent ([#104](#104)) ([ef39327](ef39327))
|
🎉 This PR is included in version 2.4.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
JurajNyiri
pushed a commit
to JurajNyiri/node-sdk-core
that referenced
this pull request
Aug 22, 2024
Bumps [typedoc](https://github.com/TypeStrong/TypeDoc) from 0.20.10 to 0.20.13. - [Release notes](https://github.com/TypeStrong/TypeDoc/releases) - [Commits](TypeStrong/typedoc@v0.20.10...v0.20.13) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, if a user set
disableSslVerificationto true and also provided their own httpsAgent (to configure a proxy, etc), thedisableSslVerificationhandling would be overwritten. We would create an httpsAgent with the required property, but the user's agent would get used instead.Now, if the user provides their own agent, the code will update the user's agent to add the required property. This way, if a user ever specifies
disableSslVerificationto true, it will always be handled properly at the agent level.