Patch series to fix key-handling and test cases #16

bpradipt · 2020-03-15T17:28:58Z

No description provided.

mkumatag

Reviewed and few minor changes required.

pkg/crypto/crypto.go

pkg/rakshctl/cmd/app/create.go

pkg/rakshctl/cmd/app/create_test.go

tests/rakshctl/app/create_app_test.go

tests/rakshctl/image/create_image_only_test.go

mkumatag

LGTM

bpradipt added 13 commits March 15, 2020 22:54

Remove vault integration

35988ff

Add required secrets for Raksh

b58fc7d

Don't add key to initrd.

0e6a04d

Remove irrevelant test case related to updating initrd

d7f4cde

Generate YAML for secret

acae73c

Add .gitignore file

81ba7dd

Fix crypto test

aa91e50

Mount Raksh secrets as Volumes

4904177

Use base64 encoded data for the keys and nonce

219f020

Fix TestEncryptConfigMapFiles

fc904ab

Fix test case for Raksh Secrets

e7eb86c

Fix test cases due to change of CLI option

f69c980

Fix secure yaml generation for multi-container POD

f42923a

bpradipt requested a review from mkumatag March 15, 2020 17:29

bpradipt self-assigned this Mar 15, 2020

This was referenced Mar 15, 2020

Avoid adding keys to initrd when not running in VM TEE #15

Closed

Fix Raksh key handling #14

Closed

mkumatag suggested changes Mar 16, 2020

View reviewed changes

bpradipt added 5 commits March 16, 2020 19:29

Add additional tests for non-existing symmKey and nonce

3a1842f

Fix raksh-secret.yaml output file placement based on CLI option

717c2b1

Update description of nonce

6fb74ff

Add tests for --insecure option

1357e08

Add test case for raksh secret file generation

7aec6f6

bpradipt force-pushed the master branch from 05df60b to 7aec6f6 Compare March 16, 2020 16:36

mkumatag approved these changes Mar 16, 2020

View reviewed changes

bpradipt merged commit 6b2e4df into IBM:master Mar 16, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Patch series to fix key-handling and test cases #16

Patch series to fix key-handling and test cases #16

bpradipt commented Mar 15, 2020

mkumatag left a comment

mkumatag left a comment

Patch series to fix key-handling and test cases #16

Patch series to fix key-handling and test cases #16

Conversation

bpradipt commented Mar 15, 2020

mkumatag left a comment

Choose a reason for hiding this comment

mkumatag left a comment

Choose a reason for hiding this comment