Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sets ConfigEntry.Default flag in addition to the ConfigEntry.Source for Kafka versions > V1_1_0_0 #1594

Merged
merged 4 commits into from
Feb 21, 2020
Merged

Sets ConfigEntry.Default flag in addition to the ConfigEntry.Source for Kafka versions > V1_1_0_0 #1594

merged 4 commits into from
Feb 21, 2020

Commits on Jan 31, 2020

  1. Set describeConfigsRequest.Version in ListTopics for consistency with… 

    … DescribeConfig

This breaks the output of ListTopics for newer request versions, it now includes default configuration settings.
    @sladkoff
    sladkoff committed Jan 31, 2020
    Configuration menu
    Copy the full SHA
    a45ea83 View commit details
    Browse the repository at this point in the history

  2. Set ConfigEntry.Default for KafkaVersions > 0 

    Clients can now rely on the `Default` flag again and don't have to check the `Source` for higher Kafka versions.
    @sladkoff
    sladkoff committed Jan 31, 2020
    Configuration menu
    Copy the full SHA
    26c3bc5 View commit details
    Browse the repository at this point in the history

  3. Set ConfigEntry.Source to default for KafkaVersions <= 0 when applicable

    @sladkoff
    sladkoff committed Jan 31, 2020
    Configuration menu
    Copy the full SHA
    1b5e305 View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2020

  1. Add tests for default flag/source

    @sladkoff
    sladkoff committed Feb 13, 2020
    Configuration menu
    Copy the full SHA
    1f4a446 View commit details
    Browse the repository at this point in the history