Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing metadata and assignment methods in describegroups #756

Merged
merged 2 commits into from
Oct 18, 2016

Conversation

pcallewaert
Copy link

The code did already exists in sync_group_response.go, but added them also in describe_groups_response.go.
Now you can read the MemberAssignment and MemberMetadata also (before it was raw bytes, and not that easy to get the actual structs)

@wvanbergen
Copy link
Contributor

Can you add a unit test for this?

@eapache
Copy link
Contributor

eapache commented Oct 4, 2016

Also please be consistent with the variable name you assign the GroupMemberDescription; the rest of the file uses gmd.

@pcallewaert
Copy link
Author

@eapache my bad, fixed

@wvanbergen I started adding them, but the encoder/decoder is already tested in consumer_group_members_test.go. This is also being used in the SyncGroupResponse. In SyncGroupResponse only the bytes are tested, so following this practice I did not add them.

@pcallewaert
Copy link
Author

Any update on this? :)

@eapache
Copy link
Contributor

eapache commented Oct 17, 2016

Sorry about that. Looks fine to me. @wvanbergen ?

@wvanbergen
Copy link
Contributor

👍 - I'd still like to see some tests for this but if we're currently not doing that elsewhere either, I am OK with leaving that for now.

@eapache eapache merged commit 1548006 into IBM:master Oct 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants