Feature/upgrade and set to alpine3.7 and openssl #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o 3.6). Also upgrade open-ssl and ca-certificates. 1. In GA v1 flex and provision base images were set to alpine:latest (back then it was 3.6). We should not use latest tag in dockerfile any more, so I set it to alpine:3.7 which is now the latest alpine version. 2. Upgrade to alpine 3.7 requires to upgrade also: ca-certificates 20161130-r2 --> 20171114-r0 openssl 1.0.2k-r0 --> 1.0.2n-r0
|
Review status: 0 of 3 files reviewed at latest revision, all discussions resolved. Comments from Reviewable |
shay-berman
deleted the
feature/upgrade_and_set_to_alpine3.7_and_openssl
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ubiquity-k8s-flex and ubiquity-k8s-provisioner base images in GA v1.0 was set to alpine:latest (back then it was alpine version 3.6). We should not use "latest" tag in Dockerfile any more, so I set it to alpine:3.7 which is now the latest alpine version. So this PR set specific alpine tag version and also upgrade to 3.7 compare to GA v1.0.
In addition setting specific version for ca-certificates to 20171114-r0
How to test
#> kubectl exec -n ubiquity -it <POD> -- cat /etc/alpine-releaseIn addition check the new packages version
#> kubectl exec -n ubiquity -it <POD> -- apk info -v | egrep "ca-cert(You can also use the google image tool for testing it)
This PR is similar to ubiquity server PR that upgrade to alpine 3.8 openssl and also ca-certificates for the ubiqutiy server base image -> IBM/ubiquity#189.
This change is