This repository has been archived by the owner on Jul 22, 2024. It is now read-only.
Upgrade image to alpine 3.7. Also upgrade openssl and ca-certificates versions. #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Also open-ssl and ca-certificates. 1. In GA v1 ubiquity base image was set to alpine:latest (back then it was 3.6). We should not use latest tag in dockerfile any more, so I set it to alpine:3.7 which is now the latest alpine version. 2. Upgrade to alpine 3.7 requires to upgrade also: ca-certificates 20161130-r2 --> 20171114-r0 openssl 1.0.2k-r0 --> 1.0.2n-r0
|
Passed ubiquity sanity test |
|
Review status: 0 of 1 files reviewed at latest revision, all discussions resolved. Comments from Reviewable |
|
Great! So, should I go ahead and close: #184 ? |
shay-berman
deleted the
feature/upgrade_and_set_to_alpine3.7_and_openssl
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ubiquity base image in GA v1.0 was set to alpine:latest (back then it was alpine version 3.6).
We should not use "latest" tag in dockerfile any more, so I set it to alpine:3.7 which is now the latest alpine version. So setting specific tag version and also upgrade to 3.7.
Upgrade alpine 3.7 requires to upgrade also the following packages in the docker image:
ca-certificates 20161130-r2 --> 20171114-r0
openssl 1.0.2k-r0 --> 1.0.2n-r0
Thanks Peeyush gupta @Pensu for indicating about the wrong dependencies with the latest alpine version.
How to test
Install ubiquity and then jump inside the ubiquity pod and check the new alpine version
#> kubectl exec -n ubiquity -it <POD> -- cat /etc/alpine-releaseIn addition check the new packages version
#> kubectl exec -n ubiquity -it <POD> -- apk info -v | egrep "openssl|ca-cert(You can also use the google image tool for testing it)
Since we change some openssl and certificate, we also should check installing ubiquity with dedicate certificates and make sure it works well.
(Automatic test should be developed for that)
This change is