Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Commit

Permalink
Ub-1060: fix tests
Browse files Browse the repository at this point in the history
  • Loading branch information
Olga Shtivelman committed Sep 3, 2018
1 parent f6d6bae commit 55e88ae
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ func (b *blockDeviceMounterUtils) UnmountDeviceFlow(devicePath string, volumeWwn
return b.logger.ErrorRet(err, "Dmsetup failed")
}

err := b.blockDeviceUtils.UmountFs(devicePath, volumeWwn)
err = b.blockDeviceUtils.UmountFs(devicePath, volumeWwn)
if err != nil {
return b.logger.ErrorRet(err, "UmountFs failed")
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,7 @@ var _ = Describe("block_device_mounter_utils_test", func() {
FIt("should fail if dmsetup failed", func() {
fakeBlockDeviceUtils.SetDmsetupReturns(callErr)
fakeBlockDeviceUtils.UmountFsReturns(nil)
err = blockDeviceMounterUtils.UnmountDeviceFlow("fake_device")
err = blockDeviceMounterUtils.UnmountDeviceFlow("fake_device", "6001738CFC9035EA0000000000795164")
Expect(err).To(HaveOccurred())
Expect(err).To(MatchError(callErr))
Expect(fakeBlockDeviceUtils.SetDmsetupCallCount()).To(Equal(1))
Expand Down
2 changes: 1 addition & 1 deletion remote/mounter/block_device_utils/mpath.go
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,7 @@ func (b *blockDeviceUtils) Cleanup(mpath string) error {
if err := b.exec.IsExecutable(multipathCmd); err != nil {
return b.logger.ErrorRet(&commandNotFoundError{multipathCmd, err}, "failed")
}
args = []string{"-f", dev}
args := []string{"-f", dev}
if _, err := b.exec.ExecuteWithTimeout(CleanupTimeout, multipathCmd, args); err != nil {
return b.logger.ErrorRet(&CommandExecuteError{multipathCmd, err}, "failed")
}
Expand Down

0 comments on commit 55e88ae

Please sign in to comment.