update script for pushing iamges to docker hub

[27149chen]

Signed-off-by: 27149chen 7991675+27149chen@users.noreply.github.com

---

This change is 

[coveralls]

Coverage remained the same at 59.175% when pulling aa2bc31 on feature/update_push_dockerhub_script into 8994dcf on dev.

[shay-berman]

Reviewable status: 0 of 1 files reviewed, 3 unresolved discussions (waiting on @27149chen and @shay-berman)

---

scripts/ci/helper_to_push_ubiquity_images_and_manifests.sh, line 56 at r1 (raw file):

ubiquity_flex_envs="in_UBIQUITY_K8S_FLEX_IMAGE_AMD64 out_UBIQUITY_K8S_FLEX_IMAGE_AMD64 in_UBIQUITY_K8S_FLEX_IMAGE_PPC64LE out_UBIQUITY_K8S_FLEX_IMAGE_PPC64LE in_UBIQUITY_K8S_FLEX_IMAGE_S390X out_UBIQUITY_K8S_FLEX_IMAGE_S390X out_UBIQUITY_K8S_FLEX_IMAGE_MULTIARCH"
ubiquity_flex_sidecar_envs="in_UBIQUITY_K8S_FLEX_SIDECAR_IMAGE_AMD64 out_UBIQUITY_K8S_FLEX_SIDECAR_IMAGE_AMD64 in_UBIQUITY_K8S_FLEX_SIDECAR_IMAGE_PPC64LE out_UBIQUITY_K8S_FLEX_SIDECAR_IMAGE_PPC64LE in_UBIQUITY_K8S_FLEX_SIDECAR_IMAGE_S390X out_UBIQUITY_K8S_FLEX_SIDECAR_IMAGE_S390X out_UBIQUITY_K8S_FLEX_SIDECAR_IMAGE_MULTIARCH"
ubiquity_helm_envs="in_UBIQUITY_K8S_HELM_IMAGE_AMD64 out_UBIQUITY_K8S_HELM_IMAGE_AMD64 in_UBIQUITY_K8S_HELM_IMAGE_PPC64LE out_UBIQUITY_K8S_HELM_IMAGE_PPC64LE in_UBIQUITY_K8S_HELM_IMAGE_S390X out_UBIQUITY_K8S_HELM_IMAGE_S390X out_UBIQUITY_K8S_HELM_IMAGE_MULTIARCH"

the word helm here is a bit confusing. if u can please:

1. rename it to ubiquity_helmhook_envs.
2. rename all the env names HELM -> HELMHOOK

and of course change other places when used.

---

scripts/ci/helper_to_push_ubiquity_images_and_manifests.sh, line 70 at r1 (raw file):

push_arch_images_and_create_manifest_for_app "Ubiquity"              $in_UBIQUITY_IMAGE_AMD64                 $out_UBIQUITY_IMAGE_AMD64                          $in_UBIQUITY_IMAGE_PPC64LE                 $out_UBIQUITY_IMAGE_PPC64LE                          $in_UBIQUITY_IMAGE_S390X                 $out_UBIQUITY_IMAGE_S390X                          $out_UBIQUITY_IMAGE_MULTIARCH                  $TAG_LATEST

Lou
looks like some indentation change in these 5 lines, which should not be touched.
Please push commit that don't touch these lines, because its not related to the helm\side car.

---

scripts/ci/helper_to_push_ubiquity_images_and_manifests.sh, line 76 at r1 (raw file):

push_arch_images_and_create_manifest_for_app "Ubiquity provisioner"   $in_UBIQUITY_K8S_PROVISIONER_IMAGE_AMD64   $out_UBIQUITY_K8S_PROVISIONER_IMAGE_AMD64          $in_UBIQUITY_K8S_PROVISIONER_IMAGE_PPC64LE   $out_UBIQUITY_K8S_PROVISIONER_IMAGE_PPC64LE          $in_UBIQUITY_K8S_PROVISIONER_IMAGE_S390X   $out_UBIQUITY_K8S_PROVISIONER_IMAGE_S390X          $out_UBIQUITY_K8S_PROVISIONER_IMAGE_MULTIARCH    $TAG_LATEST
push_arch_images_and_create_manifest_for_app "Ubiquity flex"          $in_UBIQUITY_K8S_FLEX_IMAGE_AMD64          $out_UBIQUITY_K8S_FLEX_IMAGE_AMD64                 $in_UBIQUITY_K8S_FLEX_IMAGE_PPC64LE          $out_UBIQUITY_K8S_FLEX_IMAGE_PPC64LE                 $in_UBIQUITY_K8S_FLEX_IMAGE_S390X          $out_UBIQUITY_K8S_FLEX_IMAGE_S390X                 $out_UBIQUITY_K8S_FLEX_IMAGE_MULTIARCH           $TAG_LATEST
push_arch_images_and_create_manifest_for_app "Ubiquity flex sidecar"  $in_UBIQUITY_K8S_FLEX_SIDECAR_IMAGE_AMD64  $out_UBIQUITY_K8S_FLEX_SIDECAR_IMAGE_AMD64         $in_UBIQUITY_K8S_FLEX_SIDECAR_IMAGE_PPC64LE  $out_UBIQUITY_K8S_FLEX_SIDECAR_IMAGE_PPC64LE         $in_UBIQUITY_K8S_FLEX_SIDECAR_IMAGE_S390X  $out_UBIQUITY_K8S_FLEX_SIDECAR_IMAGE_S390X         $out_UBIQUITY_K8S_FLEX_SIDECAR_IMAGE_MULTIARCH   $TAG_LATEST

these r the 2 lines that should be added.
which is ok.