Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to fuse sources with disjoint splits #707

Merged
merged 3 commits into from
Mar 26, 2024

Conversation

yoavkatz
Copy link
Member

(e.g one with "train" split and one with "test" split)

…" and one with "test")

Signed-off-by: Yoav Katz <katz@il.ibm.com>
@yoavkatz yoavkatz requested a review from eladven March 25, 2024 09:31
@yoavkatz yoavkatz self-assigned this Mar 25, 2024
Copy link

codecov bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.04%. Comparing base (cb35ff1) to head (62c3823).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #707      +/-   ##
==========================================
+ Coverage   90.00%   90.04%   +0.04%     
==========================================
  Files          96       96              
  Lines        9460     9499      +39     
==========================================
+ Hits         8514     8553      +39     
  Misses        946      946              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yoavkatz yoavkatz enabled auto-merge (squash) March 26, 2024 07:08
@yoavkatz yoavkatz disabled auto-merge March 26, 2024 07:09
@yoavkatz yoavkatz enabled auto-merge (squash) March 26, 2024 07:22
@yoavkatz yoavkatz disabled auto-merge March 26, 2024 07:33
Signed-off-by: Yoav Katz <katz@il.ibm.com>
@yoavkatz yoavkatz enabled auto-merge (squash) March 26, 2024 07:38
@yoavkatz yoavkatz merged commit 43e8e10 into main Mar 26, 2024
8 checks passed
dafnapension pushed a commit that referenced this pull request Mar 27, 2024
* Add ability to fuse sources with disjoint splits (e.g one with "train" and one with "test")

Signed-off-by: Yoav Katz <katz@il.ibm.com>

* Added MultipleSourceLoader that wraps FixedFusion

Signed-off-by: Yoav Katz <katz@il.ibm.com>

---------

Signed-off-by: Yoav Katz <katz@il.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants