Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

domesticated safety and regard #983

Merged
merged 2 commits into from
Jul 2, 2024
Merged

domesticated safety and regard #983

merged 2 commits into from
Jul 2, 2024

Conversation

dafnapension
Copy link
Collaborator

No description provided.

@dafnapension
domesticated safety and regard
bb55226 
Signed-off-by: dafnapension <dafnashein@yahoo.com>
@dafnapension
safety has reward_name rather than model_name
4506da4 
Signed-off-by: dafnapension <dafnashein@yahoo.com>
elronbandel
elronbandel approved these changes Jul 2, 2024
View reviewed changes
Copy link
Member

@elronbandel elronbandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks!!

@elronbandel elronbandel merged commit 0a94488 into main Jul 2, 2024
8 checks passed
@elronbandel elronbandel deleted the regard branch July 2, 2024 18:43
eladven added a commit that referenced this pull request Jul 4, 2024
@eladven
Revert "Implelment safety and regard metrics in pure unitxt (#983)"
7013653 
This reverts commit 0a94488.
Reason for the revert: This commmit added the class Safety. Same class is already implemented in fm-eval. Since this class is registered, we can havetwo classes with the same name. We should move the implementation for fm-eval to unitxt.
eladven added a commit that referenced this pull request Jul 7, 2024
@eladven
Revert "Implelment safety and regard metrics in pure unitxt (#983)" (#…
2e02bb4 
…997)

This reverts commit 0a94488.
Reason for the revert: This commmit added the class Safety. Same class is already implemented in fm-eval. Since this class is registered, we can havetwo classes with the same name. We should move the implementation for fm-eval to unitxt.
gitMichal pushed a commit that referenced this pull request Jul 15, 2024
@dafnapension @gitMichal
Implelment safety and regard metrics in pure unitxt (#983)
7a1c431 
* domesticated safety and regard

Signed-off-by: dafnapension <dafnashein@yahoo.com>

* safety has reward_name rather than model_name

Signed-off-by: dafnapension <dafnashein@yahoo.com>

---------

Signed-off-by: dafnapension <dafnashein@yahoo.com>
gitMichal pushed a commit that referenced this pull request Jul 15, 2024
@eladven @gitMichal
Revert "Implelment safety and regard metrics in pure unitxt (#983)" (#…
422793c 
…997)

This reverts commit 0a94488.
Reason for the revert: This commmit added the class Safety. Same class is already implemented in fm-eval. Since this class is registered, we can havetwo classes with the same name. We should move the implementation for fm-eval to unitxt.
csrajmohan pushed a commit that referenced this pull request Aug 29, 2024
@dafnapension @csrajmohan
Implelment safety and regard metrics in pure unitxt (#983)
6db43ad 
* domesticated safety and regard

Signed-off-by: dafnapension <dafnashein@yahoo.com>

* safety has reward_name rather than model_name

Signed-off-by: dafnapension <dafnashein@yahoo.com>

---------

Signed-off-by: dafnapension <dafnashein@yahoo.com>
csrajmohan pushed a commit that referenced this pull request Aug 29, 2024
@eladven @csrajmohan
Revert "Implelment safety and regard metrics in pure unitxt (#983)" (#…
69e2758 
…997)

This reverts commit 0a94488.
Reason for the revert: This commmit added the class Safety. Same class is already implemented in fm-eval. Since this class is registered, we can havetwo classes with the same name. We should move the implementation for fm-eval to unitxt.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elronbandel elronbandel elronbandel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dafnapension @elronbandel