Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade #190

Merged
merged 7 commits into from
Sep 17, 2019
Merged

Upgrade #190

merged 7 commits into from
Sep 17, 2019

Conversation

sanjeevghimire
Copy link
Contributor

  • workspace dialogs and intent modification
  • IAM implementation
  • Web UI message formatting.

markstur
markstur previously requested changes Sep 13, 2019
View reviewed changes
Copy link
Contributor

@markstur markstur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments, I think just fix travis and clean out the commented old code. Using content catalog and web ui formatting could be done later.

markstur
markstur reviewed Sep 16, 2019
View reviewed changes
Copy link
Contributor

@markstur markstur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm if it passes travis

  • wondering who else might want to review and if anyone is reviewing the workspace dialog

re: the catalog content we can talk later, but I only mentioned it because I thought you were making changes in that area

rhagarty
rhagarty reviewed Sep 16, 2019
View reviewed changes
Copy link
Member

@rhagarty rhagarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should probably get rid of the amazon product path since no one is using it/asking for it. Just clutters the code and adds to testing

@rhagarty rhagarty merged commit 1cab933 into master Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markstur markstur markstur left review comments

@rhagarty rhagarty rhagarty left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sanjeevghimire @markstur @rhagarty