Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MQTT: Support for error output port #18

Closed
chanskw opened this issue Apr 21, 2014 · 2 comments
Closed

MQTT: Support for error output port #18

chanskw opened this issue Apr 21, 2014 · 2 comments

Comments

@chanskw
Copy link
Collaborator

chanskw commented Apr 21, 2014

  1. add error output port for MQTTSource and MQTTSink
  2. Add replacement for output function for getError()
  3. Determine how errors should really be handled and what should get sent down to the error output port.
@chanskw chanskw added this to the 1.0M2 milestone Apr 21, 2014
@chanskw
Copy link
Collaborator Author

chanskw commented Jun 10, 2014

For MQTTSource, we submit an error tuple if:

  1. when we get an invalid control signal
  2. when we handle the control signal, there is any exception when interfacing with the MQTT client.

Given that Java operators cannot support output assignment, I do not see why it is useful to provide replacement for the getError() method. The error output port would only allow for a single attribute of rstring or ustring for error message. I do not see how the user can provide a different schema and be able to fully initialize attributes other than the error message attribute.

@chanskw
Copy link
Collaborator Author

chanskw commented Jun 12, 2014

For MqttSink, we submit error tuple if:

  1. when we get a control signal with invalid qos, or invalid serverUri
  2. file a warning for empty topic
  3. for invalid qos, the entire control signal will be ignored.
  4. for empty topic, the topic will be ignored, but the rest of the topics from the signals will be processed

No replacement for getError() method as I do not see how it is useful with the new operators at this point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant