Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tooltips and make them consistent as possible. There are still differences in Firefox. #1128

Merged
merged 2 commits into from Nov 3, 2022

Conversation

drjoho
Copy link
Contributor

@drjoho drjoho commented Oct 26, 2022

  • Extension UI bug

This PR is related to the following issue(s):

#1096

Additional information can be found here:

Testing reference:

I have conducted the following for this PR:

  • I validated this code in Chrome and FF
  • I validated this fix in my local env
  • I provided details for testing
  • This PR has been reviewed and is ready for test
  • I understand that the title of this PR will be used for the next release notes.

@ErickRenteria
Copy link
Contributor

This needs a second look from dev @drjoho

@marcjohlic
Copy link
Member

Fix is primarily for Chrome. The ESC to close Tool Tip does not close on FF - but we've decided to push the PR through anyway.

@ErickRenteria
Copy link
Contributor

Validated

@ErickRenteria ErickRenteria reopened this Nov 3, 2022
@ErickRenteria ErickRenteria merged commit 0b24d4f into master Nov 3, 2022
@tombrunet tombrunet deleted the joho-tooltipESC-4993 branch February 8, 2023 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants