Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(engine): Remapping engine rules from 4.1.1 Parsing to HTML and ARIA #1686

Merged
merged 28 commits into from
Oct 2, 2023

Conversation

shunguoy
Copy link
Contributor

@shunguoy shunguoy commented Sep 18, 2023

  • Modified help files: element_id_unique, element_accesskey_unique, element_accesskey_labelled, element_attribute_deprecated, aria_attribute_deprecated, aria_role_redundant
  • Rule remapping: element_id_unique, element_accesskey_unique, element_attribute_deprecated, aria_attribute_deprecated, aria_role_redundant

This PR is related to the following issue(s):

Additional information can be found here:

Testing reference:

  • test/v2/checker/accessibility/rules/aria_attribute_deprecated_ruleunit/aria-directory-deprecated.html
    To duplicate: select guidance "IBM Accessibility", an NR: The ARIA role "directory" is deprecated in the ARIA specification
    Once switching to WCAG 2.1 or WCAG 2.0 guidance, the NR should be gone.

I have conducted the following for this PR:

  • I validated this code in Chrome and FF
  • I validated this fix in my local env
  • I provided details for testing
  • This PR has been reviewed and is ready for test
  • I understand that the title of this PR will be used for the next release notes.

@philljenkins philljenkins changed the title fix<engine> remapping SC 4.1.1 in the engine rules fix(engine): Remapping engine rules from 4.1.1 Parsing to HTML and ARIA Sep 19, 2023
@philljenkins
Copy link
Contributor

@shunguoy Is that a build fail we can control?

... accessibility-checker-test-wdio (18.x (pull request)
FAILED in chrome - file:///test/specs/example.e2e.ts

@shunguoy
Copy link
Contributor Author

@philljenkins this is web driver created recently, and I am not sure why it failed and if we need to fix it.

@philljenkins
Copy link
Contributor

@ErickRenteria Is this a web driver build fail that we need to fix?

... accessibility-checker-test-wdio (18.x (pull request)
FAILED in chrome - file:///test/specs/example.e2e.ts

@shunguoy shunguoy marked this pull request as ready for review September 20, 2023 16:00
tombrunet
tombrunet previously approved these changes Sep 22, 2023
@shunguoy shunguoy requested review from ErickRenteria and removed request for ErickRenteria September 25, 2023 20:10
@ErickRenteria
Copy link
Contributor

Validated

@ErickRenteria ErickRenteria merged commit e124556 into master Oct 2, 2023
15 checks passed
@tombrunet tombrunet deleted the dev-1680 branch April 11, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants