Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

newrule(element_tabbable_unobscured): WCAG 2.2: 2.4.11 Focus not obscured (Minimum) #1705

Merged
merged 48 commits into from
Oct 25, 2023

Conversation

shunguoy
Copy link
Contributor

@shunguoy shunguoy commented Oct 4, 2023

  • New Rule(s): element_tabbable_unobscured

This PR is related to the following issue(s):

Additional information can be found here:

Testing reference:

  • first from the checker settings, select "WCAG 2.2 (A, AA)" guideline
    -- Then run the following test case, you should see an NR "Confirm that when the element receives focus, it is not covered or, if covered by user action, can be uncovered without moving focus" test/v2/checker/accessibility/rules/element_tabbable_unobscured_ruleunit/element_overlaid_hidden_default.html

I have conducted the following for this PR:

  • I validated this code in Chrome and FF
  • I validated this fix in my local env
  • I provided details for testing
  • This PR has been reviewed and is ready for test
  • I understand that the title of this PR will be used for the next release notes.

@philljenkins philljenkins changed the title newrule<'element_tabbable_unobscured'>: WCAG 2.2 Focus not obscured requirement newrule(element_tabbable_unobscured): WCAG 2.2 - 2.4.11 Focus not obscured (Minimum) Oct 6, 2023
@philljenkins philljenkins changed the title newrule(element_tabbable_unobscured): WCAG 2.2 - 2.4.11 Focus not obscured (Minimum) newrule(element_tabbable_unobscured): WCAG 2.2: 2.4.11 Focus not obscured (Minimum) Oct 6, 2023
@shunguoy shunguoy marked this pull request as ready for review October 11, 2023 20:00
@philljenkins philljenkins linked an issue Oct 19, 2023 that may be closed by this pull request
3 tasks
tombrunet
tombrunet previously approved these changes Oct 20, 2023
Copy link
Contributor

@philljenkins philljenkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also reviewed the WCAG 2.2 rule set changes, and corrected a link to the Understanding page

@philljenkins
Copy link
Contributor

philljenkins commented Oct 23, 2023

And I fixed the 4.1..1 heading to include a description in #1725

Added description for when 4.1.1 is listed in Rule Sets
Copy link
Contributor

@philljenkins philljenkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The two changes made after Tom's review passed the build test.

@ErickRenteria
Copy link
Contributor

Validated

@ErickRenteria ErickRenteria merged commit e1f154b into master Oct 25, 2023
15 checks passed
@philljenkins philljenkins changed the title newrule(element_tabbable_unobscured): WCAG 2.2: 2.4.11 Focus not obscured (Minimum) newrule(element_tabbable_unobscured): WCAG 2.2: 2.4.11 Focus not obscured (Minimum) Nov 8, 2023
@Seirdy
Copy link

Seirdy commented Nov 9, 2023

Flattered that you linked me in the passing test case :3

I use your checker all the time so this feels nice.

@tombrunet tombrunet deleted the dev-1676 branch April 11, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants