Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

newrule(target_spacing_sufficient): WCAG 2.2: 2.5.8 Target size (minimum) #1719

Merged
merged 57 commits into from
Nov 9, 2023

Conversation

shunguoy
Copy link
Contributor

@shunguoy shunguoy commented Oct 17, 2023

  • New Rule(s): target_spacing_sufficient
  • New or modified help files: target_spacing_sufficient.html

This PR is related to the following issue(s):

Additional information can be found here:

Testing reference:

  • Select "WCA_2_2" ruleset from the checker settings. then scan the following test case:
    ...test/v2/checker/accessibility/rules/target_spacing_sufficient_ruleunit/element_target.html

Note: due to a mapping issue (#1731), the 'Violation' is showing up as "Recommendation' now. "Undersized target "{0}" does not have sufficient spacing of 12 CSS pixels from another target "{1}"",

I have conducted the following for this PR:

  • I validated this code in Chrome and FF
  • I validated this fix in my local env
  • I provided details for testing
  • This PR has been reviewed and is ready for test
  • I understand that the title of this PR will be used for the next release notes.

@philljenkins philljenkins changed the title newrule('target_spacing_sufficient'): WCAG 2.2 minimum target size newrule(target_spacing_sufficient): WCAG 2.2: 2.5.8 Target size (minimum) Oct 19, 2023
@philljenkins philljenkins linked an issue Oct 25, 2023 that may be closed by this pull request
7 tasks
philljenkins and others added 2 commits October 25, 2023 12:54
include the title as well as the technique SCR20:
philljenkins and others added 8 commits November 6, 2023 11:38
Co-authored-by: Tom Brunet <thbrunet@us.ibm.com>
Co-authored-by: Tom Brunet <thbrunet@us.ibm.com>
Co-authored-by: Tom Brunet <thbrunet@us.ibm.com>
Co-authored-by: Tom Brunet <thbrunet@us.ibm.com>
Copy link
Contributor

@philljenkins philljenkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good editorial changes

@philljenkins philljenkins changed the title newrule(target_spacing_sufficient): WCAG 2.2: 2.5.8 Target size (minimum) newrule(target_spacing_sufficient): WCAG 2.2: 2.5.8 Target size (minimum) Nov 8, 2023
Co-authored-by: Tom Brunet <thbrunet@us.ibm.com>
tombrunet
tombrunet previously approved these changes Nov 8, 2023
tombrunet
tombrunet previously approved these changes Nov 8, 2023
@ErickRenteria
Copy link
Contributor

@shunguoy we have a few conflicts, please review.

@ErickRenteria
Copy link
Contributor

Validated
Screenshot 2023-11-09 at 5 03 35 PM

@ErickRenteria ErickRenteria merged commit e0b4359 into master Nov 9, 2023
15 checks passed
@tombrunet tombrunet deleted the dev-1674 branch April 11, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants