Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(extension): Options updated for selecting WCAG 2.2 related rules #1741

Merged
merged 15 commits into from
Nov 22, 2023

Conversation

philljenkins
Copy link
Contributor

@philljenkins philljenkins commented Nov 10, 2023

  1. Extension UI "IBM Accessibility Checker options" page update
  2. Rule set info pop-up update for "Select a rule set deployment date"
  3. Guidelines info pop-up update for "Select an accessibility guideline"

This PR is related to the following issue(s):

Additional information can be found here:

Testing procedures:

  1. Open Checker settings
  2. Open Rule set info icon at the "Select a rule set deployment date" heading
  3. Review the pop-up for text format, grammar, etc.
  4. Select the Preview Rules option at the end
  5. Open Guidelines info icon at the "Select an accessibility guideline" heading
  6. Review the pop-up for text format, grammar, etc.
  7. Select the WCAG 2.2 (A, AA) option
  8. Save

image
image

I have conducted the following for this PR:

  • I validated this code in Chrome and FF
  • I validated this fix in my local env
  • I provided details for testing
  • This PR has been reviewed and is ready for test
  • I understand that the title of this PR will be used for the next release notes.

@philljenkins philljenkins self-assigned this Nov 10, 2023
@philljenkins philljenkins added the extension-checker Issues related to the browser extensions label Nov 10, 2023
@philljenkins
Copy link
Contributor Author

philljenkins commented Nov 10, 2023

Now seeing new options in the Action
Options

@philljenkins philljenkins marked this pull request as ready for review November 10, 2023 23:54
philljenkins and others added 13 commits November 13, 2023 10:12
Co-authored-by: Tom Brunet <thbrunet@us.ibm.com>
Co-authored-by: Tom Brunet <thbrunet@us.ibm.com>
Co-authored-by: Tom Brunet <thbrunet@us.ibm.com>
Co-authored-by: Tom Brunet <thbrunet@us.ibm.com>
Co-authored-by: Tom Brunet <thbrunet@us.ibm.com>
Co-authored-by: Tom Brunet <thbrunet@us.ibm.com>
Co-authored-by: Tom Brunet <thbrunet@us.ibm.com>
missing end P
fixed formatting and link size
@philljenkins
Copy link
Contributor Author

@tombrunet Comments committed or resolved, ready for re-review & approval
Options

Copy link
Contributor Author

@philljenkins philljenkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edits committed and conversations resolved

@philljenkins philljenkins added Ready for QA and removed extension-checker Issues related to the browser extensions labels Nov 14, 2023
@ErickRenteria
Copy link
Contributor

Validated

@ErickRenteria ErickRenteria merged commit 06c7ba6 into master Nov 22, 2023
15 checks passed
@tombrunet tombrunet deleted the phill-5966-WCAG22-options branch April 11, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants