Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(references): Update links to WCAG 2.2 where used #1747

Merged
merged 11 commits into from
Nov 29, 2023

Conversation

philljenkins
Copy link
Contributor

@philljenkins philljenkins commented Nov 14, 2023

  • Engine and Rules
  • Extensionlinks
  • Toolkit - Requirements - Checker Rule Sets

This PR is related to the following issue(s):

Additional information can be found here:

Testing reference:

I have conducted the following for this PR:

  • I validated this code in Chrome and FF
  • I validated this fix in my local env
  • I provided details for testing
  • This PR has been reviewed and is ready for test
  • I understand that the title of this PR will be used for the next release notes.

shunguoy
shunguoy previously approved these changes Nov 14, 2023
tombrunet
tombrunet previously approved these changes Nov 14, 2023
shunguoy
shunguoy previously approved these changes Nov 15, 2023
@philljenkins
Copy link
Contributor Author

philljenkins commented Nov 15, 2023

Fixed broken test case

@philljenkins
Copy link
Contributor Author

When checking the "Checker rule sets" page via action artifact Rule listing, I found missing definitions for 3 new WCAG 2.2 SCs that don't have any rules yet.

  • missing definitions examples:
    3 3 7 and 3 3 8

  • Definitions added for new WCAG 2.2 SCs that don't have rules mapped to them
    3 3 7 and 3 3 8 defined

tombrunet
tombrunet previously approved these changes Nov 16, 2023
Copy link
Contributor

@ErickRenteria ErickRenteria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review

@@ -67,7 +67,7 @@ <h3 id="ruleMessage"></h3>
### About this requirement

* [IBM 1.1.1 Non-text content](https://www.ibm.com/able/requirements/requirements/#1_1_1)
* [WCAG technique H86](https://www.w3.org/WAI/WCAG21/Techniques/html/H86)
* [WCAG technique H86: Providing text alternatives for emojis, emoticons, ASCII art, and leetspeak: Providing text alternatives for emojis, emoticons, ASCII art, and leetspeak: Providing text alternatives for emojis, emoticons, ASCII art, and leetspeak](https://www.w3.org/WAI/WCAG22/Techniques/html/H86)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed redundancy, its odd that it was "repeated" 3 times

Removed redundancy from emoticons_alt_exists.html
@ErickRenteria ErickRenteria merged commit 82771ce into master Nov 29, 2023
15 checks passed
@tombrunet tombrunet deleted the phill-1696-WCAG22-links branch April 11, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update links in 2.0/2.1 HELP to new & latest techniques published by W3C in WCAG 2.2
4 participants