Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(engine): fix issues related to element text calculation #1759

Merged
merged 8 commits into from
Dec 12, 2023

Conversation

shunguoy
Copy link
Contributor

@shunguoy shunguoy commented Nov 28, 2023

  • Rule bug: label_content_exists, input_label_before

This PR is related to the following issue(s):

#1557

Additional information can be found here:

Testing reference:

test case: test/v2/checker/accessibility/rules/label_content_exists_ruleunit/label-invisible-element.html
The following false positive violations should be fixed:

  • The element does not have descriptive text that identifies the expected input
  • Form control element has no associated label

I have conducted the following for this PR:

  • I validated this code in Chrome and FF
  • I validated this fix in my local env
  • I provided details for testing
  • This PR has been reviewed and is ready for test
  • I understand that the title of this PR will be used for the next release notes.

@philljenkins philljenkins linked an issue Dec 11, 2023 that may be closed by this pull request
@ErickRenteria ErickRenteria merged commit b3bcc87 into master Dec 12, 2023
15 checks passed
@tombrunet tombrunet deleted the dev-1557 branch April 11, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: Label descriptions within details elements flagging rule
3 participants