fixrule(style_focus_visible): Reduce "Needs Review” issues for CSS border or outline
#1833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shunguoy
changed the title
style_focus_visible): fix some ‘Needs Review” false positivesstyle_focus_visible): fix some ‘Needs Review” false positives
shunguoy
changed the title
style_focus_visible): fix some ‘Needs Review” false positivesstyle_focus_visible): fix some "Needs Review” false positives
tombrunet
approved these changes
Feb 12, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
philljenkins
changed the title
style_focus_visible): fix some "Needs Review” false positivesstyle_focus_visible): Reduce some "Needs Review” false positives
|
Validated |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
philljenkins
changed the title
style_focus_visible): Reduce some "Needs Review” false positivesstyle_focus_visible): Reduce "Needs Review” issues for CSS border or outline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to the following issue(s):
#1645
Testing reference:
test page: https://www.ibm.com/us-en
Use the extension filters: Requirements and "Needs Review" only
without the fix: approximately 93 "Needs Review" with the message: "Check the keyboard focus indicator is highly visible when using CSS declaration for 'border' or 'outline'"
After the fix: approximately 10 "Needs Review" with the same message.
I have conducted the following for this PR: