Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixrule(text_sensory_misuse): Reduce "Needs Review" false positives for sensory text #1855

Merged
merged 7 commits into from
Mar 13, 2024

Conversation

shunguoy
Copy link
Contributor

@shunguoy shunguoy commented Feb 26, 2024

fixrule(text_sensory_misuse): Reduce "Needs Review" false positives for the rule

Please review more info: https://github.com/IBMa/equal-access/wiki/Release-notes -->

  • Rule bug: text_sensory_misuse

This PR is related to the following issue(s):

#1641

Additional information can be found here:

Testing reference:

1.3.3 Sensory Characteristics:
first test case: test/v2/checker/accessibility/rules/text_sensory_misuse_ruleunit/Content-notSensory-hidden.html
before fix: 1 message: "If the word(s) 'round, square, shape, rectangle, triangle, right, left, top-left, top-right, bottom-right, bottom-left, above, below, top, bottom, upper, lower, corner, beside' is part of instructions for using page content, check it is still understandable without this location or shape information"
after fix: 2 messages: "Confirm the word(s) 'right, left, top-left, top-right, bottom-right, bottom-left, above, below, top, bottom, upper, lower, corner, beside' of the user instruction is used to indicate a logical rather than visual position"
and "Confirm the user instruction is still understandable without the word(s) 'round, square, shape, rectangle, triangle'"

Second test case: test/v2/checker/accessibility/rules/text_sensory_misuse_ruleunit/right-click.html
before fix: 2 messages
after fix: 1 message

I have conducted the following for this PR:

  • I validated this code in Chrome and FF
  • I validated this fix in my local env
  • I provided details for testing
  • This PR has been reviewed and is ready for test
  • I understand that the title of this PR will be used for the next release notes.

@shunguoy shunguoy changed the title fixrule(text_sensory_misuse): Reduce "Needs Review" false positives for the rule fixrule(text_sensory_misuse): Reduce "Needs Review" false positives for the sensory text Feb 26, 2024
@shunguoy shunguoy changed the title fixrule(text_sensory_misuse): Reduce "Needs Review" false positives for the sensory text fixrule(text_sensory_misuse): Reduce "Needs Review" false positives for sensory text Feb 28, 2024
@shunguoy shunguoy requested a review from tombrunet March 1, 2024 14:24
@shunguoy shunguoy marked this pull request as ready for review March 1, 2024 14:24
tombrunet
tombrunet previously approved these changes Mar 7, 2024
@shunguoy shunguoy dismissed tombrunet’s stale review March 7, 2024 15:37

The merge-base changed after approval.

@ErickRenteria
Copy link
Contributor

Validated
Screenshot 2024-03-12 at 9 26 42 PM

@ErickRenteria ErickRenteria added this pull request to the merge queue Mar 13, 2024
Merged via the queue into master with commit 75a7b89 Mar 13, 2024
15 checks passed
@tombrunet tombrunet deleted the dev-1641 branch April 11, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants