fixrule(text_block_heading
): Reduce false positives on block headings
#1865
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following formats should be use for the release notes and PRs.
Rule/Engine updates:
fixrule(
text_block_heading
) Reduce false positives on block headingsPlease review more info: https://github.com/IBMa/equal-access/wiki/Release-notes -->
This PR is related to the following issue(s):
Additional information can be found here:
Testing reference:
filter to the Requirement "1.3.1 Info and Relationships" and "Needs Review"
Test case 1: test/v2/checker/accessibility/rules/text_block_heading_ruleunit/text_style.html
After the fix, 5 new NR messages appear: like "Confirm this text 'Fake Heading 1' is used as a heading and if so, modify to use a heading element or role"
Test case 2: test/v2/checker/accessibility/rules/text_block_heading_ruleunit/text_ignore.html
After the fix, the NR message disappear: "Check if this text should be marked up as a heading: test options test 0 test 1 test 2"
I have conducted the following for this PR: