Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixrule(text_block_heading): Reduce false positives on block headings #1865

Merged
merged 10 commits into from
Apr 9, 2024

Conversation

shunguoy
Copy link
Contributor

@shunguoy shunguoy commented Mar 11, 2024

The following formats should be use for the release notes and PRs.

Rule/Engine updates:
fixrule(text_block_heading) Reduce false positives on block headings

Please review more info: https://github.com/IBMa/equal-access/wiki/Release-notes -->

  • Rule bug: text_block_heading

This PR is related to the following issue(s):

Additional information can be found here:

Testing reference:

filter to the Requirement "1.3.1 Info and Relationships" and "Needs Review"
Test case 1: test/v2/checker/accessibility/rules/text_block_heading_ruleunit/text_style.html
After the fix, 5 new NR messages appear: like "Confirm this text 'Fake Heading 1' is used as a heading and if so, modify to use a heading element or role"
Test case 2: test/v2/checker/accessibility/rules/text_block_heading_ruleunit/text_ignore.html
After the fix, the NR message disappear: "Check if this text should be marked up as a heading: test options test 0 test 1 test 2"

I have conducted the following for this PR:

  • I validated this code in Chrome and FF
  • I validated this fix in my local env
  • I provided details for testing
  • This PR has been reviewed and is ready for test
  • I understand that the title of this PR will be used for the next release notes.

@shunguoy shunguoy requested a review from tombrunet March 13, 2024 19:59
@shunguoy shunguoy marked this pull request as ready for review March 13, 2024 19:59
@philljenkins philljenkins changed the title fixrule(text_block_heading) Reduce false positives on block headings fixrule(text_block_heading): Reduce false positives on block headings Mar 27, 2024
@ErickRenteria ErickRenteria added this pull request to the merge queue Apr 9, 2024
Merged via the queue into master with commit 040a3f7 Apr 9, 2024
15 checks passed
@tombrunet tombrunet deleted the dev-1638 branch April 11, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revisit: text_block_heading - can we tighten scope?
3 participants