Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixrule(input_autocomplete_valid): Support "webauthn" autocomplete attribute #1879

Merged
merged 3 commits into from
Apr 10, 2024

Conversation

shunguoy
Copy link
Contributor

@shunguoy shunguoy commented Mar 22, 2024

The following formats should be use for the release notes and PRs.

Rule/Engine updates:
fixrule(input_autocomplete_valid): Support "webauthn" autocomplete attribute

Please review more info: https://github.com/IBMa/equal-access/wiki/Release-notes -->

  • Rule bug: input_autocomplete_valid

This PR is related to the following issue(s):

Fixes #1757

Additional information can be found here:

Testing reference:

test case: test/v2/checker/accessibility/rules/input_autocomplete_valid_ruleunit/act-pass.html
before the fix: A Violation message:
after the fix: the violation should disappear.

I have conducted the following for this PR:

  • I validated this code in Chrome and FF
  • I validated this fix in my local env
  • I provided details for testing
  • This PR has been reviewed and is ready for test
  • I understand that the title of this PR will be used for the next release notes.

@ErickRenteria ErickRenteria added this pull request to the merge queue Apr 10, 2024
@ErickRenteria
Copy link
Contributor

validsted

Merged via the queue into master with commit 05abf9b Apr 10, 2024
15 checks passed
@tombrunet tombrunet deleted the dev-1757 branch April 11, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: input_autocomplete_valid fails for ACT pass testcase
3 participants