Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(extension): adjust hidden counts #1883

Merged
merged 4 commits into from
Apr 11, 2024
Merged

fix(extension): adjust hidden counts #1883

merged 4 commits into from
Apr 11, 2024

Conversation

drjoho
Copy link
Contributor

@drjoho drjoho commented Mar 26, 2024 •
edited

fixes #1882

Testing reference:

Eric see me for testing

I have conducted the following for this PR:

  • I validated this code in Chrome and FF
  • I validated this fix in my local env
  • I provided details for testing
  • This PR has been reviewed and is ready for test
  • I understand that the title of this PR will be used for the next release notes.

@drjoho drjoho requested a review from tombrunet March 26, 2024 18:37
tombrunet
tombrunet previously approved these changes Mar 26, 2024
View reviewed changes
@drjoho drjoho requested a review from tombrunet March 27, 2024 03:23
@ErickRenteria
Copy link
Contributor

validated

@ErickRenteria ErickRenteria added this pull request to the merge queue Apr 11, 2024
Merged via the queue into master with commit 3253831 Apr 11, 2024
15 checks passed
@tombrunet tombrunet deleted the joho-HiddenCount-1882 branch April 11, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tombrunet tombrunet tombrunet approved these changes

Assignees
No one assigned
Labels
Ready for QA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: Hidden counting error between current scan report and chrome local storage
3 participants
@drjoho @ErickRenteria @tombrunet