Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(extension|node|karma|cypress): Properly close the embedded browser #1891

Merged
merged 16 commits into from
Apr 17, 2024

Conversation

shunguoy
Copy link
Contributor

@shunguoy shunguoy commented Apr 10, 2024

The following formats should be used for the release notes and PRs.

**Tool updates:
fix(extension|node|karma|cypress): Properly close the embedded browser

Please review more info: https://github.com/IBMa/equal-access/wiki/Release-notes -->

  • Engine bug:

This PR is related to the following issue(s):

fixes: #1837

Testing reference:

I have conducted the following for this PR:

  • I validated this code in Chrome and FF
  • I validated this fix in my local env
  • I provided details for testing
  • This PR has been reviewed and is ready for test
  • I understand that the title of this PR will be used for the next release notes.

@shunguoy shunguoy changed the title fix(engine): Properly close the engine #1837 fix(engine): Properly close the engine Apr 10, 2024
@shunguoy shunguoy changed the title fix(engine): Properly close the engine fix(extension|node|karma|cypress): Properly close the embedded browser Apr 10, 2024
@shunguoy shunguoy requested a review from tombrunet April 11, 2024 18:59
@shunguoy shunguoy marked this pull request as ready for review April 11, 2024 18:59
@tombrunet tombrunet added this pull request to the merge queue Apr 17, 2024
Merged via the queue into master with commit 7195485 Apr 17, 2024
15 checks passed
@shunguoy shunguoy deleted the dev-1837 branch April 18, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

npm- Unable to Generate xlsx file (and csv). Able to generate html, json
2 participants