Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

newrule(svg_graphics_labelled): Create a new rule to check the accessible name of an SVG element #1909

Merged
merged 17 commits into from
Jun 24, 2024

Conversation

shunguoy
Copy link
Contributor

@shunguoy shunguoy commented May 15, 2024

  • New Rule(s): svg_graphics_labelled
  • New or modified help files: svg_graphics_labelled

This PR is related to the following issue(s):

fixes: #1471
fixes: #1905 Help

Testing reference:

test case: test/v2/checker/accessibility/rules/svg_graphics_labelled_ruleunit/svg_nested_all_fail.html
Three violations reported for the SVG elements: The SVG element has no accessible name

I have conducted the following for this PR:

  • I validated this code in Chrome and FF
  • I validated this fix in my local env
  • I provided details for testing
  • This PR has been reviewed and is ready for test
  • I understand that the title of this PR will be used for the next release notes.

New test item

@shunguoy shunguoy changed the title newrule(svg_graphics_labelled): Create the rule to check the accessible name of an SVG element newrule(svg_graphics_labelled): Create a new rule to check the accessible name of an SVG element May 17, 2024
@philljenkins philljenkins requested a review from drjoho June 11, 2024 15:31
@philljenkins philljenkins marked this pull request as ready for review June 11, 2024 21:04
Copy link
Contributor

@drjoho drjoho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all files. No obvious errors.

@ErickRenteria
Copy link
Contributor

Validated
Screenshot 2024-06-24 at 6 30 00 PM

@ErickRenteria ErickRenteria merged commit 7a88182 into master Jun 24, 2024
15 checks passed
@tombrunet tombrunet deleted the dev-1471 branch August 2, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Help content for the svg rule Accessibility issues of SVG elements in the engine
4 participants