-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
newrule(svg_graphics_labelled
): Create a new rule to check the accessible name of an SVG element
#1909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svg_graphics_labelled
): Create the rule to check the accessible name of an SVG elementsvg_graphics_labelled
): Create a new rule to check the accessible name of an SVG element
drjoho
approved these changes
Jun 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all files. No obvious errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to the following issue(s):
fixes: #1471
fixes: #1905 Help
Testing reference:
test case: test/v2/checker/accessibility/rules/svg_graphics_labelled_ruleunit/svg_nested_all_fail.html
Three violations reported for the SVG elements: The SVG element has no accessible name
I have conducted the following for this PR:
New test item
Make sure to add a check for the Checker rule sets tab content to the Test for Done in the next rollout of the rules. The check will be to confirm that 7.3 appears as a new tab. This new/additional test step is mentioned in https://github.ibm.com/IBMa/E2E/issues/6463NA for this PR