Use warnings.warn instead of logging.warn when loading Problem from H… #1253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #1253 +/- ##
===========================================
+ Coverage 84.38% 84.42% +0.04%
===========================================
Files 153 153
Lines 12450 12451 +1
===========================================
+ Hits 10506 10512 +6
+ Misses 1944 1939 -5 ☔ View full report in Codecov by Sentry. |
PaulJonasJost
approved these changes
Dec 17, 2023
| 'WARNING: You are loading a problem.\nThis problem' | ||
| ' is not to be used without a separately created' | ||
| ' objective.' | ||
| warnings.warn( |
There was a problem hiding this comment.
why not logger.warn? 🤔
There was a problem hiding this comment.
Because then I can't easily silence just this warning
…DF5 without an Objective Allows using warnings filter to get rid of this message.
dweindl
force-pushed
the
hdf5_problem_obj_warn
branch
from
8490233
to
4361f6b
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…DF5 without an Objective
Allows using warnings filters to get rid of this message.
e.g.,
Wait until next amici release for #1252 to be fixed.