Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: Prettify petab.select docs #1255

Merged
merged 1 commit into from
Dec 17, 2023
Merged

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Dec 17, 2023

Fix return type documentation, cross references, typo, deprecated type annotations.

Fix return type documentation, cross references, typo, deprecated type annotations.
@codecov-commenter
Copy link

codecov-commenter commented Dec 17, 2023

Codecov Report

Attention: 384 lines in your changes are missing coverage. Please review.

Comparison is base (160c2a8) 88.16% compared to head (7f40c2b) 82.48%.
Report is 475 commits behind head on develop.

Files Patch % Lines
pypesto/ensemble/ensemble.py 69.77% 68 Missing ⚠️
...ypesto/hierarchical/spline_approximation/solver.py 82.62% 53 Missing ⚠️
pypesto/ensemble/util.py 65.13% 38 Missing ⚠️
pypesto/hierarchical/optimal_scaling/solver.py 93.53% 26 Missing ⚠️
pypesto/history/base.py 88.57% 24 Missing ⚠️
pypesto/hierarchical/petab.py 84.76% 23 Missing ⚠️
pypesto/engine/mpi_pool.py 0.00% 22 Missing ⚠️
pypesto/hierarchical/inner_calculator_collector.py 88.51% 17 Missing ⚠️
...pesto/hierarchical/spline_approximation/problem.py 89.18% 16 Missing ⚠️
pypesto/hierarchical/problem.py 89.05% 15 Missing ⚠️
... and 15 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1255      +/-   ##
===========================================
- Coverage    88.16%   82.48%   -5.69%     
===========================================
  Files           79      148      +69     
  Lines         5257    12066    +6809     
===========================================
+ Hits          4635     9953    +5318     
- Misses         622     2113    +1491     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@dilpath dilpath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@dweindl dweindl merged commit d161a9a into ICB-DCM:develop Dec 17, 2023
16 of 18 checks passed
@dweindl dweindl deleted the doc_prettify_select branch December 17, 2023 18:01
This was referenced Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants