add bounds check fixes #515 and fixes #509 #516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yannikschaelte
approved these changes
Nov 23, 2020
| @@ -199,8 +205,14 @@ def normalize(self) -> None: | |||
| raise AssertionError("x_names must be of length dim_full.") | |||
| if len(self.x_fixed_indices) != len(self.x_fixed_vals): | |||
| raise AssertionError( | |||
| "x_fixed_indices and x_fixed_vals musti have the same length." | |||
| "x_fixed_indices and x_fixed_vals must have the same length." | |||
Codecov Report
@@ Coverage Diff @@
## develop #516 +/- ##
===========================================
+ Coverage 90.19% 90.23% +0.04%
===========================================
Files 72 72
Lines 4283 4291 +8
===========================================
+ Hits 3863 3872 +9
+ Misses 420 419 -1
Continue to review full report at Codecov.
|
FFroehlich
reviewed
Nov 23, 2020
Co-authored-by: Fabian Fröhlich <fabian@schaluck.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.