-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added engines to profiling as well as engine_test in test_profile #532
Conversation
Thanks @PaulJonasJost , much appreciated! |
Codecov Report
@@ Coverage Diff @@
## develop #532 +/- ##
===========================================
+ Coverage 87.94% 88.43% +0.48%
===========================================
Files 69 71 +2
Lines 4405 4443 +38
===========================================
+ Hits 3874 3929 +55
+ Misses 531 514 -17
Continue to review full report at Codecov.
|
@PaulJonasJost sorry, we did not respond overly quickly here. Could you rerun the tests to see whether all works with the latest releases of AMICI and PEtab? Then this should be almost gtg (@jvanhoefer @dilpath ?). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
|
||
# check results | ||
for count, _engine in enumerate(engines): | ||
for j in range(len(self.result.profile_result.list[0])): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for j in range(len(self.result.profile_result.list[0])): | |
for j in range(1, len(self.result.profile_result.list[0])): |
I guess the first can be skipped
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why can the first be skipped? i think the first count can be skipped not j.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, meant count
, added a new suggestion.
Co-authored-by: Dilan Pathirana <59329744+dilpath@users.noreply.github.com>
Co-authored-by: Dilan Pathirana <59329744+dilpath@users.noreply.github.com>
Co-authored-by: Dilan Pathirana <59329744+dilpath@users.noreply.github.com>
Co-authored-by: Dilan Pathirana <59329744+dilpath@users.noreply.github.com>
Co-authored-by: Dilan Pathirana <59329744+dilpath@users.noreply.github.com>
Hello,
i added the engines to the profiling. Currently (until approval) i left the option to use the current version of profiling when using
engine=None
. I also added a test in test_profiles.Kind regards,
Paul