added engines to profiling as well as engine_test in test_profile

[PaulJonasJost]

Hello,

i added the engines to the profiling. Currently (until approval) i left the option to use the current version of profiling when using engine=None. I also added a test in test_profiles.

Kind regards,
Paul

[yannikschaelte]

Thanks @PaulJonasJost , much appreciated!

[codecov-io]

Codecov Report

Merging #532 (0b071dd) into develop (df705ce) will increase coverage by 0.48%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #532      +/-   ##
===========================================
+ Coverage    87.94%   88.43%   +0.48%     
===========================================
  Files           69       71       +2     
  Lines         4405     4443      +38     
===========================================
+ Hits          3874     3929      +55     
+ Misses         531      514      -17     

Impacted Files	Coverage Δ
pypesto/profile/profile.py	91.89% <100.00%> (-2.76%)	⬇️
pypesto/profile/task.py	100.00% <100.00%> (ø)
pypesto/profile/walk_along_profile.py	100.00% <100.00%> (ø)
pypesto/objective/amici_calculator.py	90.00% <0.00%> (+1.66%)	⬆️
pypesto/profile/options.py	92.30% <0.00%> (+7.69%)	⬆️
pypesto/engine/multi_process.py	92.30% <0.00%> (+7.69%)	⬆️
pypesto/engine/multi_thread.py	100.00% <0.00%> (+8.00%)	⬆️
pypesto/objective/amici_util.py	83.03% <0.00%> (+8.92%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df705ce...0b071dd. Read the comment docs.

[yannikschaelte]

@PaulJonasJost sorry, we did not respond overly quickly here. Could you rerun the tests to see whether all works with the latest releases of AMICI and PEtab? Then this should be almost gtg (@jvanhoefer @dilpath ?).

[dilpath]

Looks good 👍

[dilpath]

Suggested change

	for j in range(len(self.result.profile_result.list[0])):
	for j in range(1, len(self.result.profile_result.list[0])):

I guess the first can be skipped

[PaulJonasJost]

why can the first be skipped? i think the first count can be skipped not j.

[dilpath]

Oops, meant count, added a new suggestion.