-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature hdf5 profile sample #546
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #546 +/- ##
===========================================
+ Coverage 88.22% 89.47% +1.24%
===========================================
Files 71 71
Lines 4443 4532 +89
===========================================
+ Hits 3920 4055 +135
+ Misses 523 477 -46
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to have HDF5 IO support for profiling/sampling results.
Please also include a test case writing some result, reading it back in and ensuring that it is the same as the original one.
Co-authored-by: Daniel Weindl <dweindl@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good for me now.
…DCM/pyPESTO into feature_hdf5_Profile_Sample
Hello,
i created a Reader and Writer for both Profiles and Samples.
I do need to mention that there is still some slight bug, when writing into an already existing file. It then expectes the shape to be the same as before (e.g. a profile of a parameter which ad (20,1) before is now expected to have the same shape). I do have an Idea on how to fix this but this here is already working right now. One only has to create a new file or delete the old before as of now.