Add parameter names to check_grad results #644
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #644 +/- ##
===========================================
+ Coverage 88.16% 89.80% +1.63%
===========================================
Files 79 93 +14
Lines 5257 5953 +696
===========================================
+ Hits 4635 5346 +711
+ Misses 622 607 -15
Continue to review full report at Codecov.
|
pypesto/objective/base.py
Outdated
| @@ -527,7 +527,8 @@ def check_grad( | |||
| data = {**prefix_data, **data, **postfix_data} | |||
|
|
|||
| # create dataframe | |||
| result = pd.DataFrame(data=data) | |||
| result = pd.DataFrame(data=data, | |||
| index=[self.x_names[ix] for ix in x_indices]) | |||
There was a problem hiding this comment.
self.x_names defaults to None. Not sure if this will ever be the case here though.
There was a problem hiding this comment.
I think whenever parameter names are used, a good default are p0, ... / p_0, ... / x0, ..., or sth like that.
There was a problem hiding this comment.
cannot add default names to objective since dimension of x is not known at initialization
pypesto/objective/base.py
Outdated
| @@ -527,7 +527,8 @@ def check_grad( | |||
| data = {**prefix_data, **data, **postfix_data} | |||
|
|
|||
| # create dataframe | |||
| result = pd.DataFrame(data=data) | |||
| result = pd.DataFrame(data=data, | |||
| index=[self.x_names[ix] for ix in x_indices]) | |||
There was a problem hiding this comment.
I think whenever parameter names are used, a good default are p0, ... / p_0, ... / x0, ..., or sth like that.
Co-authored-by: Dilan Pathirana <59329744+dilpath@users.noreply.github.com>
No description provided.