Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed default values of read_result #649

Merged
merged 1 commit into from
Apr 30, 2021

Conversation

PaulJonasJost
Copy link
Collaborator

This way it still loads everything given no arguments, but only loads desired values if anything is specified.

Copy link
Member

@dilpath dilpath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codecov-commenter
Copy link

codecov-commenter commented Apr 30, 2021

Codecov Report

Merging #649 (518c8ce) into develop (160c2a8) will increase coverage by 1.67%.
The diff coverage is 87.30%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #649      +/-   ##
===========================================
+ Coverage    88.16%   89.84%   +1.67%     
===========================================
  Files           79       93      +14     
  Lines         5257     5958     +701     
===========================================
+ Hits          4635     5353     +718     
+ Misses         622      605      -17     
Impacted Files Coverage Δ
pypesto/ensemble/covariance_analysis.py 18.36% <0.00%> (-0.39%) ⬇️
pypesto/optimize/__init__.py 100.00% <ø> (ø)
pypesto/objective/amici.py 85.56% <20.00%> (-4.27%) ⬇️
pypesto/predict/task.py 43.75% <43.75%> (ø)
pypesto/petab/__init__.py 63.63% <50.00%> (ø)
pypesto/objective/amici_util.py 84.21% <66.66%> (+8.31%) ⬆️
pypesto/engine/mpi_pool.py 68.18% <68.18%> (ø)
pypesto/ensemble/constants.py 91.30% <71.42%> (-8.70%) ⬇️
pypesto/visualize/misc.py 82.41% <72.22%> (-2.52%) ⬇️
pypesto/store/read_from_hdf5.py 91.47% <78.94%> (+33.57%) ⬆️
... and 65 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 540d9e8...518c8ce. Read the comment docs.

@PaulJonasJost PaulJonasJost merged commit 15ec4ab into develop Apr 30, 2021
@PaulJonasJost PaulJonasJost deleted the change_read_result_function branch April 30, 2021 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants