Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tests +small bug fix in validation intervals fixes #674, #675 #676

Merged
merged 1 commit into from
May 25, 2021

Conversation

jvanhoefer
Copy link
Member

  • More detailed tests: Test e.g. if the "perfect" prediction gives p=1.0 and if the significance decreases with increasing mismatch between prediction and measurement.

  • Bug fix: There was a sign error in the validation interval computation, that led to wrong results...

@codecov-commenter
Copy link

codecov-commenter commented May 25, 2021

Codecov Report

Merging #676 (1c08614) into develop (160c2a8) will increase coverage by 2.16%.
The diff coverage is 89.07%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #676      +/-   ##
===========================================
+ Coverage    88.16%   90.33%   +2.16%     
===========================================
  Files           79       96      +17     
  Lines         5257     6363    +1106     
===========================================
+ Hits          4635     5748    +1113     
+ Misses         622      615       -7     
Impacted Files Coverage Δ
pypesto/ensemble/covariance_analysis.py 18.36% <0.00%> (-0.39%) ⬇️
pypesto/optimize/__init__.py 100.00% <ø> (ø)
pypesto/ensemble/utils.py 57.57% <22.22%> (-5.59%) ⬇️
pypesto/predict/task.py 43.75% <43.75%> (ø)
pypesto/petab/__init__.py 63.63% <50.00%> (ø)
pypesto/objective/amici.py 83.67% <51.85%> (-6.16%) ⬇️
pypesto/problem.py 91.57% <58.33%> (+0.34%) ⬆️
pypesto/objective/amici_util.py 84.21% <66.66%> (+8.31%) ⬆️
pypesto/engine/mpi_pool.py 68.18% <68.18%> (ø)
pypesto/visualize/misc.py 82.41% <72.22%> (-2.52%) ⬇️
... and 81 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5cce409...1c08614. Read the comment docs.

@jvanhoefer jvanhoefer merged commit 0461449 into develop May 25, 2021
@yannikschaelte yannikschaelte deleted the feature_tests_validation_intervals branch July 6, 2021 13:50
@yannikschaelte yannikschaelte mentioned this pull request Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sign error in validation intervals Add more tests to validation intervals
3 participants