Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed ensemble from optimization #688

Merged
merged 1 commit into from
Jun 30, 2021

Conversation

PaulJonasJost
Copy link
Collaborator

Noticed a mistake in the implementation, as x_names, ub, lb where from the full parameter vector, while the vectors from optimization only contain the non fixed. Adjusted it so that it is consistent with the optimization parameters.

@codecov-commenter
Copy link

codecov-commenter commented Jun 30, 2021

Codecov Report

Merging #688 (fe7b45e) into develop (45e8a50) will increase coverage by 0.17%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #688      +/-   ##
===========================================
+ Coverage    90.18%   90.35%   +0.17%     
===========================================
  Files           96       96              
  Lines         6399     6400       +1     
===========================================
+ Hits          5771     5783      +12     
+ Misses         628      617      -11     
Impacted Files Coverage Δ
pypesto/ensemble/ensemble.py 82.30% <100.00%> (+0.07%) ⬆️
pypesto/objective/amici_calculator.py 93.33% <0.00%> (+1.66%) ⬆️
pypesto/objective/amici_util.py 84.21% <0.00%> (+8.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45e8a50...fe7b45e. Read the comment docs.

Copy link
Member

@dilpath dilpath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PaulJonasJost PaulJonasJost merged commit a6aef21 into develop Jun 30, 2021
@PaulJonasJost PaulJonasJost deleted the fix_ensemble_with_fixed_para branch June 30, 2021 14:01
@yannikschaelte yannikschaelte mentioned this pull request Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants