Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to scale parameters in pypesto.visualize.parameters #693

Merged
merged 4 commits into from
Jul 8, 2021
Merged

Add option to scale parameters in pypesto.visualize.parameters #693

merged 4 commits into from
Jul 8, 2021

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Jul 7, 2021

Closes #692

@codecov-commenter
Copy link

codecov-commenter commented Jul 7, 2021 •
edited
Loading

Codecov Report

Merging #693 (86ccd95) into develop (c0df8d6) will increase coverage by 0.14%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #693      +/-   ##
===========================================
+ Coverage    89.93%   90.08%   +0.14%     
===========================================
  Files           96       96              
  Lines         6507     6513       +6     
===========================================
+ Hits          5852     5867      +15     
+ Misses         655      646       -9
Impacted Files Coverage Δ
pypesto/visualize/parameters.py 92.38% <100.00%> (+0.46%) ⬆️
pypesto/sample/geweke_test.py 91.54% <0.00%> (-2.82%) ⬇️
pypesto/objective/amici_calculator.py 93.33% <0.00%> (+1.66%) ⬆️
pypesto/objective/amici_util.py 84.21% <0.00%> (+8.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0df8d6...86ccd95. Read the comment docs.

yannikschaelte
yannikschaelte approved these changes Jul 8, 2021
View reviewed changes
Copy link
Member

@yannikschaelte yannikschaelte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a test won't hurt

pypesto/visualize/parameters.py Outdated
@@ -23,7 +23,8 @@ def parameters(
colors: Optional[Union[List[float], List[List[float]]]] = None,
legends: Optional[Union[str, List[str]]] = None,
balance_alpha: bool = True,
start_indices: Optional[Union[int, Iterable[int]]] = None
start_indices: Optional[Union[int, Iterable[int]]] = None,
scale: Optional[Tuple[float, float]] = None,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"scale" is a bit over-used. "(re)scaled_bounds"?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replaced

@dweindl dweindl merged commit fd4bbc3 into develop Jul 8, 2021
@dweindl dweindl deleted the feature_692_scaled_parplot branch July 8, 2021 09:30
@yannikschaelte yannikschaelte mentioned this pull request Aug 2, 2021
Merged
@dweindl dweindl mentioned this pull request Oct 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yannikschaelte yannikschaelte yannikschaelte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dweindl @codecov-commenter @yannikschaelte