Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix fides #741

Merged
merged 4 commits into from
Oct 14, 2021
Merged

fix fides #741

merged 4 commits into from
Oct 14, 2021

Conversation

FFroehlich
Copy link
Contributor

fixes mismatch between fval from optimizer and history (fides was pretending it is returning fvals while it was actually returning chi2 values.

@codecov-commenter
Copy link

codecov-commenter commented Oct 14, 2021

Codecov Report

Merging #741 (a67a54f) into develop (0c88715) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #741   +/-   ##
========================================
  Coverage    33.83%   33.83%           
========================================
  Files           99       99           
  Lines         6730     6730           
========================================
  Hits          2277     2277           
  Misses        4453     4453           
Impacted Files Coverage Δ
pypesto/optimize/optimizer.py 82.60% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c88715...a67a54f. Read the comment docs.

@FFroehlich FFroehlich merged commit 815583c into develop Oct 14, 2021
@FFroehlich FFroehlich deleted the fix_fides branch October 14, 2021 13:05
@yannikschaelte yannikschaelte mentioned this pull request Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants