Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable use of priors with least squares optimizers #745

Merged
merged 12 commits into from
Oct 21, 2021

Conversation

FFroehlich
Copy link
Contributor

Adds res + sres functions to priors where possible. Extends prior testcases to include multi-dimensional problems.

@codecov-commenter
Copy link

codecov-commenter commented Oct 21, 2021

Codecov Report

Merging #745 (03e5ec3) into develop (c62ebcd) will increase coverage by 0.43%.
The diff coverage is 89.47%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #745      +/-   ##
===========================================
+ Coverage    89.47%   89.90%   +0.43%     
===========================================
  Files           99       99              
  Lines         6734     6786      +52     
===========================================
+ Hits          6025     6101      +76     
+ Misses         709      685      -24     
Impacted Files Coverage Δ
pypesto/startpoint/assign.py 92.30% <ø> (+7.69%) ⬆️
pypesto/objective/base.py 87.12% <75.00%> (+5.03%) ⬆️
pypesto/objective/priors.py 86.95% <90.27%> (+6.50%) ⬆️
pypesto/optimize/optimizer.py 90.38% <0.00%> (+0.22%) ⬆️
pypesto/petab/importer.py 89.56% <0.00%> (+4.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c62ebcd...03e5ec3. Read the comment docs.

Copy link
Member

@yannikschaelte yannikschaelte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks very good.

pypesto/objective/priors.py Outdated Show resolved Hide resolved
pypesto/objective/priors.py Outdated Show resolved Hide resolved
pypesto/objective/priors.py Outdated Show resolved Hide resolved
pypesto/objective/priors.py Outdated Show resolved Hide resolved
pypesto/objective/priors.py Outdated Show resolved Hide resolved
pypesto/objective/priors.py Outdated Show resolved Hide resolved
@FFroehlich FFroehlich merged commit 074078e into develop Oct 21, 2021
@FFroehlich FFroehlich deleted the enable_prior_res branch October 21, 2021 23:52
@yannikschaelte yannikschaelte mentioned this pull request Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants