Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(problem) fix problem.get_reduced_vector #86

Merged
merged 3 commits into from
Jan 16, 2019
Merged

Conversation

FFroehlich
Copy link
Contributor

How could this not be caught by tests?

Copy link
Member

@yannikschaelte yannikschaelte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we internally only use numpy arrays such that this is possible?

@dweindl
Copy link
Member

dweindl commented Jan 10, 2019

I guess we internally only use numpy arrays such that this is possible?

This is maybe something to discuss / document. Whether we want to support only numpy.ndarray or also python lists. Everywhere or only in the public API (which is what exactly?)?

@yannikschaelte
Copy link
Member

Internally, I everywhere used np arrays. When something comes from public, it is converted to ndarray first. In this sense, public API is every interface where the user puts in data.

Sometimes I also used methods like .size (instead of len), which are only available for numpy. On second thoughts, this should be revised I think, and list-based methods used. When a ndarray is explicitly needed in a method, it should maybe be converted first, also to ensure e.g. the dimensions are correct.

@paulstapor
Copy link
Contributor

I would vote for using lists for free and fixed indices, since I also want to use/am using fixing and "unfixing" of parameters in profiling. Lists are more comfortable to use with .pop and .append for this.

@FFroehlich FFroehlich merged commit ada03cc into master Jan 16, 2019
@FFroehlich FFroehlich deleted the fix_parameter_plot branch January 16, 2019 22:09
m-philipps pushed a commit that referenced this pull request Jun 14, 2022
* Require Matplotlib >=3.5

* Fix changed arguments basex, basey
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants