Yan 968 #143
Merged
Yan 968 #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed travis badge link
tested nifty graphs
… to Doxygen for PyFuncApp
…cognise additional parameter types basedon default value
…arsing of parameters. Skip components whose methods begin with an underscore.
Signed-off-by: Rodrigo Tobar <rtobar@icrar.org>
We have been getting away with this code, but in reality we have always been guilty of not taking the GIL in the "pythonic" dynlibs (i.e., those offering a "init2" method rather than an "init" one). Until 3.8 no errors have showed up, but in 3.9 segfaults start to happen when calling PyLong_FromLong (and possibly other methods). To solve this I've updated our example code to take the GIL as appropriate. This is verbose, but it's the simples solution. A different approach would have been to load the dynlib with ctypes's PyDLL rather than CDLL, but that forces all C function calls to hold the GIL even if not required, which is less performant. Nobody (except Kevin, if he still does?) is using this anyway, and if so they would have run into the same error as we did here, so there's no issue in clarifying that the GIL must be taken by the dynlib code rather than by daliuge. Signed-off-by: Rodrigo Tobar <rtobar@icrar.org>
This was found while stabilising the unit tests running against python 3.9, which in turn I was doing to have a stable basis to work against for YAN-968. Signed-off-by: Rodrigo Tobar <rtobar@icrar.org>
Now that the problems with 3.9 have been solved we should be able to test against it without problems. Signed-off-by: Rodrigo Tobar <rtobar@icrar.org>
This was found while working on YAN-968. Signed-off-by: Rodrigo Tobar <rtobar@icrar.org>
When creating drops from a graph specification we used to use only the top-level key-values to build the keyword map passed down to applications, which then inspected it to obtain their user-provided arguments. For some time now LGs (and their translation into PGs) have separated how arguments are provided to applications though, grouping them together inside an applicationArgs map instead of placing them at the top-level of each drop specification. This means that applications cannot access these values directly, and that the mechanism to declare arguments at the class level (using dlg_string_param and friends) doesn't pick them up. This commit merges the information contained in applicationArgs into the set of arguments passed down to drops via kwargs. This is enough for the dlg_*_param declarations to pick these up. This is part of YAN-968. Signed-off-by: Rodrigo Tobar <rtobar@icrar.org>
This is part of YAN-968. Signed-off-by: Rodrigo Tobar <rtobar@icrar.org>
|
This pull request covers a few smallish changes which are related with the yan-968 ticket. Some part of which had been fixed by Rodrigo in a separate ticket and already merged. There are also a few other changes from different branches, which might have an influence on this and thus I've merged master back into this branch already and it looks like there are more changes than what's actually happened. |
pritchardn
reviewed
Apr 21, 2022
This seems to be what is in the code when I checked out the branch, so I'm confused why the code in the PR was different.
pritchardn
approved these changes
Apr 21, 2022
awicenec
added a commit
that referenced
this pull request
May 19, 2022
pritchardn
pushed a commit
that referenced
this pull request
May 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.