Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yan 968 #143

Merged
merged 36 commits into from
Apr 22, 2022
Merged

Yan 968 #143

merged 36 commits into from
Apr 22, 2022

Commits on Apr 6, 2022

  1. Configuration menu
    Copy the full SHA
    b9818fe View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2022

  1. Configuration menu
    Copy the full SHA
    b7e9d04 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2a7eb52 View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2022

  1. Configuration menu
    Copy the full SHA
    9e6e7b0 View commit details
    Browse the repository at this point in the history
  2. Added RDBMS for a test

    awicenec committed Apr 8, 2022
    Configuration menu
    Copy the full SHA
    0c1106a View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2022

  1. Configuration menu
    Copy the full SHA
    aad0630 View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2022

  1. Update README.rst

    Fixed travis badge link
    awicenec committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    15bdb01 View commit details
    Browse the repository at this point in the history
  2. updated nifty

    calgray authored and awicenec committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    54398cd View commit details
    Browse the repository at this point in the history
  3. gather function bugfix

    tested nifty graphs
    calgray authored and awicenec committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    bb6e4ed View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    6613940 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    c9c506e View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    a301374 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    0f3106d View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    d97941f View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    210cf87 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    6a15ea2 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    3713183 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    81c9f50 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    3e0435b View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    7c81b3e View commit details
    Browse the repository at this point in the history
  15. Set appclass correctly, add func_name, pickle arguments. Minor change…

    … to Doxygen for PyFuncApp
    james-strauss-uwa authored and awicenec committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    2d9aa18 View commit details
    Browse the repository at this point in the history
  16. Hide internal methods with names beginning with underscore. Try to re…

    …cognise additional parameter types basedon default value
    james-strauss-uwa authored and awicenec committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    1f78201 View commit details
    Browse the repository at this point in the history
  17. Cleanup output

    james-strauss-uwa authored and awicenec committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    7d9d2ab View commit details
    Browse the repository at this point in the history
  18. Optionally limit components to those in a given module path. Better p…

    …arsing of parameters. Skip components whose methods begin with an underscore.
    james-strauss-uwa authored and awicenec committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    c480f03 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    f5adf71 View commit details
    Browse the repository at this point in the history
  20. Minor changes to logging

    james-strauss-uwa authored and awicenec committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    a2f51a0 View commit details
    Browse the repository at this point in the history
  21. Avoid IndexError during url_prefix calculation

    Signed-off-by: Rodrigo Tobar <rtobar@icrar.org>
    rtobar authored and awicenec committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    eec6bde View commit details
    Browse the repository at this point in the history
  22. Acquire GIL in dynlib_example2 as appropriate

    We have been getting away with this code, but in reality we have always
    been guilty of not taking the GIL in the "pythonic" dynlibs (i.e., those
    offering a "init2" method rather than an "init" one). Until 3.8 no
    errors have showed up, but in 3.9 segfaults start to happen when calling
    PyLong_FromLong (and possibly other methods).
    
    To solve this I've updated our example code to take the GIL as
    appropriate. This is verbose, but it's the simples solution. A different
    approach would have been to load the dynlib with ctypes's PyDLL rather
    than CDLL, but that forces all C function calls to hold the GIL even if
    not required, which is less performant. Nobody (except Kevin, if he
    still does?) is using this anyway, and if so they would have run into
    the same error as we did here, so there's no issue in clarifying that
    the GIL must be taken by the dynlib code rather than by daliuge.
    
    Signed-off-by: Rodrigo Tobar <rtobar@icrar.org>
    rtobar authored and awicenec committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    6110383 View commit details
    Browse the repository at this point in the history
  23. Decrement reference on otherwise dangling object

    This was found while stabilising the unit tests running against python
    3.9, which in turn I was doing to have a stable basis to work against
    for YAN-968.
    
    Signed-off-by: Rodrigo Tobar <rtobar@icrar.org>
    rtobar authored and awicenec committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    e7c7740 View commit details
    Browse the repository at this point in the history
  24. Add python 3.9 to the Travis CI build matrix

    Now that the problems with 3.9 have been solved we should be able to
    test against it without problems.
    
    Signed-off-by: Rodrigo Tobar <rtobar@icrar.org>
    rtobar authored and awicenec committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    7b81ced View commit details
    Browse the repository at this point in the history
  25. Consider empty string params as empty dictionaries

    This was found while working on YAN-968.
    
    Signed-off-by: Rodrigo Tobar <rtobar@icrar.org>
    rtobar authored and awicenec committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    8715f0a View commit details
    Browse the repository at this point in the history
  26. Augment kwargs with values from applicationArgs

    When creating drops from a graph specification we used to use only the
    top-level key-values to build the keyword map passed down to
    applications, which then inspected it to obtain their user-provided
    arguments. For some time now LGs (and their translation into PGs) have
    separated how arguments are provided to applications though, grouping
    them together inside an applicationArgs map instead of placing them at
    the top-level of each drop specification. This means that applications
    cannot access these values directly, and that the mechanism to declare
    arguments at the class level (using dlg_string_param and friends)
    doesn't pick them up.
    
    This commit merges the information contained in applicationArgs into the
    set of arguments passed down to drops via kwargs. This is enough for the
    dlg_*_param declarations to pick these up.
    
    This is part of YAN-968.
    
    Signed-off-by: Rodrigo Tobar <rtobar@icrar.org>
    rtobar authored and awicenec committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    9d02aa2 View commit details
    Browse the repository at this point in the history
  27. Add unit test to ensure applicationArgs are read

    This is part of YAN-968.
    
    Signed-off-by: Rodrigo Tobar <rtobar@icrar.org>
    rtobar authored and awicenec committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    3eaa064 View commit details
    Browse the repository at this point in the history
  28. Corrects how dict variables are parsed

    This seems to be what is in the code when I checked out the branch, so I'm confused why the code in the PR was different.
    pritchardn committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    40c4df2 View commit details
    Browse the repository at this point in the history
  29. Configuration menu
    Copy the full SHA
    6dc317a View commit details
    Browse the repository at this point in the history
  30. Configuration menu
    Copy the full SHA
    6946e7e View commit details
    Browse the repository at this point in the history