-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Yan 968 #143
Commits on Apr 6, 2022
-
Configuration menu - View commit details
-
Copy full SHA for b9818fe - Browse repository at this point
Copy the full SHA b9818feView commit details
Commits on Apr 7, 2022
-
Configuration menu - View commit details
-
Copy full SHA for b7e9d04 - Browse repository at this point
Copy the full SHA b7e9d04View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2a7eb52 - Browse repository at this point
Copy the full SHA 2a7eb52View commit details
Commits on Apr 8, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 9e6e7b0 - Browse repository at this point
Copy the full SHA 9e6e7b0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0c1106a - Browse repository at this point
Copy the full SHA 0c1106aView commit details
Commits on Apr 12, 2022
-
Configuration menu - View commit details
-
Copy full SHA for aad0630 - Browse repository at this point
Copy the full SHA aad0630View commit details
Commits on Apr 21, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 15bdb01 - Browse repository at this point
Copy the full SHA 15bdb01View commit details -
Configuration menu - View commit details
-
Copy full SHA for 54398cd - Browse repository at this point
Copy the full SHA 54398cdView commit details -
Configuration menu - View commit details
-
Copy full SHA for bb6e4ed - Browse repository at this point
Copy the full SHA bb6e4edView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6613940 - Browse repository at this point
Copy the full SHA 6613940View commit details -
Configuration menu - View commit details
-
Copy full SHA for c9c506e - Browse repository at this point
Copy the full SHA c9c506eView commit details -
Configuration menu - View commit details
-
Copy full SHA for a301374 - Browse repository at this point
Copy the full SHA a301374View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0f3106d - Browse repository at this point
Copy the full SHA 0f3106dView commit details -
Configuration menu - View commit details
-
Copy full SHA for d97941f - Browse repository at this point
Copy the full SHA d97941fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 210cf87 - Browse repository at this point
Copy the full SHA 210cf87View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6a15ea2 - Browse repository at this point
Copy the full SHA 6a15ea2View commit details -
Fixed bug where param names specified using a 'defname' tag instead o…
…f 'declname' tag
Configuration menu - View commit details
-
Copy full SHA for 3713183 - Browse repository at this point
Copy the full SHA 3713183View commit details -
Configuration menu - View commit details
-
Copy full SHA for 81c9f50 - Browse repository at this point
Copy the full SHA 81c9f50View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3e0435b - Browse repository at this point
Copy the full SHA 3e0435bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7c81b3e - Browse repository at this point
Copy the full SHA 7c81b3eView commit details -
Set appclass correctly, add func_name, pickle arguments. Minor change…
… to Doxygen for PyFuncApp
Configuration menu - View commit details
-
Copy full SHA for 2d9aa18 - Browse repository at this point
Copy the full SHA 2d9aa18View commit details -
Hide internal methods with names beginning with underscore. Try to re…
…cognise additional parameter types basedon default value
Configuration menu - View commit details
-
Copy full SHA for 1f78201 - Browse repository at this point
Copy the full SHA 1f78201View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7d9d2ab - Browse repository at this point
Copy the full SHA 7d9d2abView commit details -
Optionally limit components to those in a given module path. Better p…
…arsing of parameters. Skip components whose methods begin with an underscore.
Configuration menu - View commit details
-
Copy full SHA for c480f03 - Browse repository at this point
Copy the full SHA c480f03View commit details -
Configuration menu - View commit details
-
Copy full SHA for f5adf71 - Browse repository at this point
Copy the full SHA f5adf71View commit details -
Configuration menu - View commit details
-
Copy full SHA for a2f51a0 - Browse repository at this point
Copy the full SHA a2f51a0View commit details -
Avoid IndexError during url_prefix calculation
Signed-off-by: Rodrigo Tobar <rtobar@icrar.org>
Configuration menu - View commit details
-
Copy full SHA for eec6bde - Browse repository at this point
Copy the full SHA eec6bdeView commit details -
Acquire GIL in dynlib_example2 as appropriate
We have been getting away with this code, but in reality we have always been guilty of not taking the GIL in the "pythonic" dynlibs (i.e., those offering a "init2" method rather than an "init" one). Until 3.8 no errors have showed up, but in 3.9 segfaults start to happen when calling PyLong_FromLong (and possibly other methods). To solve this I've updated our example code to take the GIL as appropriate. This is verbose, but it's the simples solution. A different approach would have been to load the dynlib with ctypes's PyDLL rather than CDLL, but that forces all C function calls to hold the GIL even if not required, which is less performant. Nobody (except Kevin, if he still does?) is using this anyway, and if so they would have run into the same error as we did here, so there's no issue in clarifying that the GIL must be taken by the dynlib code rather than by daliuge. Signed-off-by: Rodrigo Tobar <rtobar@icrar.org>
Configuration menu - View commit details
-
Copy full SHA for 6110383 - Browse repository at this point
Copy the full SHA 6110383View commit details -
Decrement reference on otherwise dangling object
This was found while stabilising the unit tests running against python 3.9, which in turn I was doing to have a stable basis to work against for YAN-968. Signed-off-by: Rodrigo Tobar <rtobar@icrar.org>
Configuration menu - View commit details
-
Copy full SHA for e7c7740 - Browse repository at this point
Copy the full SHA e7c7740View commit details -
Add python 3.9 to the Travis CI build matrix
Now that the problems with 3.9 have been solved we should be able to test against it without problems. Signed-off-by: Rodrigo Tobar <rtobar@icrar.org>
Configuration menu - View commit details
-
Copy full SHA for 7b81ced - Browse repository at this point
Copy the full SHA 7b81cedView commit details -
Consider empty string params as empty dictionaries
This was found while working on YAN-968. Signed-off-by: Rodrigo Tobar <rtobar@icrar.org>
Configuration menu - View commit details
-
Copy full SHA for 8715f0a - Browse repository at this point
Copy the full SHA 8715f0aView commit details -
Augment kwargs with values from applicationArgs
When creating drops from a graph specification we used to use only the top-level key-values to build the keyword map passed down to applications, which then inspected it to obtain their user-provided arguments. For some time now LGs (and their translation into PGs) have separated how arguments are provided to applications though, grouping them together inside an applicationArgs map instead of placing them at the top-level of each drop specification. This means that applications cannot access these values directly, and that the mechanism to declare arguments at the class level (using dlg_string_param and friends) doesn't pick them up. This commit merges the information contained in applicationArgs into the set of arguments passed down to drops via kwargs. This is enough for the dlg_*_param declarations to pick these up. This is part of YAN-968. Signed-off-by: Rodrigo Tobar <rtobar@icrar.org>
Configuration menu - View commit details
-
Copy full SHA for 9d02aa2 - Browse repository at this point
Copy the full SHA 9d02aa2View commit details -
Add unit test to ensure applicationArgs are read
This is part of YAN-968. Signed-off-by: Rodrigo Tobar <rtobar@icrar.org>
Configuration menu - View commit details
-
Copy full SHA for 3eaa064 - Browse repository at this point
Copy the full SHA 3eaa064View commit details -
Corrects how dict variables are parsed
This seems to be what is in the code when I checked out the branch, so I'm confused why the code in the PR was different.
Configuration menu - View commit details
-
Copy full SHA for 40c4df2 - Browse repository at this point
Copy the full SHA 40c4df2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6dc317a - Browse repository at this point
Copy the full SHA 6dc317aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6946e7e - Browse repository at this point
Copy the full SHA 6946e7eView commit details