Liu 282 #195
Merged
Liu 282 #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # daliuge-engine/dlg/apps/pyfunc.py # daliuge-engine/dlg/drop.py
|
I've merged the latest from master into this branch and factored in the recent data drop move to dlg.data. |
pritchardn
approved these changes
Aug 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request moves the creation of the session directory to the init of the session object, rather than leaving it to a FileDROP. It also moves the session log-file to that directory and changes the overall working directory for the rest of the graph execution to that. There is also an additional change to capture the main doc-string of casatasks and use them in palettes.
For some reason the test_registry.py tests failed on github when pushing with an sqlite3 operational error when trying to open the DB file. Changing the file to use tempfile fixed that.