Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflow_dispatch to the "ci" Workflow #121

Merged

Conversation

tony-laza
Copy link
Contributor

This is helpful when testing a PR to be able to manually run the workflow.

@yguel yguel merged commit 3aaca92 into ICube-Robotics:main May 2, 2024
2 checks passed
@yguel
Copy link
Contributor

yguel commented May 2, 2024

Many thanks for your contribution.
Your PR has been merged.

Side question:
We are working on using Earthly to enable users to run workflows locally, and to deploy the code on many other platform than github. Would you consider that would help you to contribute to a project like ethercat_driver_ros2 ?

@tony-laza tony-laza deleted the feature/laza-workflow-dispatch branch May 2, 2024 15:38
@tony-laza
Copy link
Contributor Author

Thanks for merging this. For our development, we have a GitHub fork of the repo, and we can run tests there (especially with this change so we can click the "start" button). Also, we're able to run colcon test locally + pre-commit which helps us run most of the tests locally. Being able to run the full workflow locally would help a bit, but I don't think it's a blocker for us. Another advantage to using Earthly might be to reduce dependence on GitHub itself in case there's a need to migrate the project to another hosting platform.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants