Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

Adding HX1D and HXNTU Notebook Examples #107

Merged
merged 26 commits into from
Dec 9, 2022

Conversation

bpaul4
Copy link
Contributor

@bpaul4 bpaul4 commented Mar 3, 2022

Fixes # .

  • New notebook examples for 1D Heat Exchanger and NTU Heat Exchanger unit models and associated index updates
  • Corrections for minor errors in index files to properly build Turbine notebook example
  • These notebooks may undergo updates in the future regarding the outcome of Standardize naming in Heat Exchanger models idaes-pse#730

Proposed changes:

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@bpaul4 bpaul4 self-assigned this Mar 3, 2022
@ksbeattie ksbeattie added the Priority:Normal Normal Priority Issue or PR label Mar 10, 2022
Copy link
Member

@andrewlee94 andrewlee94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - most of my comments are minor things.

I made a few requests on the HX0D notebook that are also applicable to the other notebooks (I didn't repeat most of them to keep things shorter).

@MarcusHolly
Copy link
Contributor

I didn't see a reason to add a separate example for the shell and tube 1D example since there seems to be significant overlap with the existing heat exchanger 1D example. However, if there's something I'm missing about it or if we just want to add a separate example for shell and tube anyway, I can do that.

Copy link
Contributor Author

@bpaul4 bpaul4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @MarcusHolly for picking up this PR and adding the lumped capacitance example. it looks very nice and I just have a few comments.

Copy link
Member

@andrewlee94 andrewlee94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor but important request - for the NTU example we need to clarify what MEA is to the general user. WE only need to write out the first instance in full however.

@MarcusHolly
Copy link
Contributor

@andrewlee94 MEA is already specified in the problem statement.

Copy link
Member

@andrewlee94 andrewlee94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MarcusHolly Ah - it is, but it is wrong. It should be monoethanolamine.

@andrewlee94 andrewlee94 enabled auto-merge (squash) December 9, 2022 20:34
@andrewlee94 andrewlee94 merged commit a9aadb0 into IDAES:main Dec 9, 2022
@bpaul4 bpaul4 deleted the heat-exchanger-examples branch September 1, 2023 13:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Priority:Normal Normal Priority Issue or PR
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

4 participants