This repository has been archived by the owner on Apr 6, 2023. It is now read-only.
Add setup.py to enable installation as idaes_examples namespace package #127
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #126
Summary/Motivation
setup.py
file making it possible to install this repository as a "proper" Python packagepkg
(to minimize conflicts/ambiguity with the existingsrc
directory)hda
andmethanol
Python files have been transferred (this choice was arbitrary and mostly done as a first pass for this draft)To install
It should be enough to run
pip install --editable .
from the root of the repository (in addition to the other setup/installation steps). Note that this can conflict with existing examples directories obtained throughidaes get-examples --local
but I'm not sure how exactly this might manifest.Open questions/before merging
from idaes_examples.common.hda.flowsheet import ...
orfrom idaes_examples.hda.flowsheet import ...
or some other alternativveLegal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: